Update azurerm_linux|windows_virtual_machine_scale_set - Fix in some circumstances updating VMSS error complaining imageReference is null

[ArcturusZhang]

Fixes #7957

[tombuildsstuff]

hey @ArcturusZhang

Thanks for this PR.

I've taken a look through and left some comments inline - whilst this approach works this does mean that it's no longer possible to conditionally ignore changes to the Source Image block - as such it'd be worth pulling this data from the API and then conditionally overriding it (as we do today) if the user has changes to these fields. However if we can fix that up then this should otherwise be good to me 👍

Thanks!

[ArcturusZhang]

Hi @tombuildsstuff I have updated my code by first assign the imageReference using the result from GET response, and then assign new imageReference if HasChange returns true. Please have a look, thanks!

[tombuildsstuff]

LGTM 👍

[tombuildsstuff]

Tests look good 👍

[ghost]

This has been released in version 2.26.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.26.0"
}
# ... other configuration ...

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!