Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_cosmosdb_account support DisableRateLimitingResponses for the capabilities property #8016

Merged
merged 2 commits into from
Aug 6, 2020

Conversation

yupwei68
Copy link
Contributor

@yupwei68 yupwei68 commented Aug 5, 2020

Fix #8011

Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @yupwei68

Taking a look through I've left one comment inline but this otherwise LGTM 👍

website/docs/r/cosmosdb_account.html.markdown Outdated Show resolved Hide resolved
Co-authored-by: Tom Harvey <tombuildsstuff@users.noreply.github.com>
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Applied suggestion and LGTM 👍

@katbyte katbyte changed the title azurerm_cosmosdb_account capabilities adds enum type azurerm_cosmosdb_account support DisableRateLimitingResponses for the capabilities property Aug 6, 2020
@katbyte katbyte added this to the v2.22.0 milestone Aug 6, 2020
@katbyte katbyte merged commit 1b5217e into hashicorp:master Aug 6, 2020
katbyte added a commit that referenced this pull request Aug 6, 2020
@ghost
Copy link

ghost commented Aug 7, 2020

This has been released in version 2.22.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.22.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Sep 6, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Sep 6, 2020
@yupwei68 yupwei68 deleted the wyp-cosmos-acc-ca branch September 14, 2020 03:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

terraform import cosmos "unknown" capability DisableRateLimitingResponses
3 participants