-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
azurerm_iothub - support for the endpoint.resource_group
property
#8032
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @neil-yechenwei - overall this looks good but i've left some comments inline that need to be addressed before merge
@katbyte , thanks for your comments. I've updated code. Please have a look. Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @neil-yechenwei, aside from one comment that needs to be addressed this LGTM 👍
@katbyte , thanks for your comment. I've updated code by your comment. Please have a look. Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @neil-yechenwei! this LGTM now
endpoint.resource_group
property
This has been released in version 2.34.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 2.34.0"
}
# ... other configuration ... |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
fixes #3295
--- PASS: TestAccAzureRMIotHub_standard (310.27s)
--- PASS: TestAccAzureRMIotHub_ipFilterRules (321.22s)
--- PASS: TestAccAzureRMIotHub_fallbackRoute (321.66s)
--- PASS: TestAccAzureRMIotHub_requiresImport (343.44s)
--- PASS: TestAccAzureRMIotHub_fileUpload (375.62s)
--- PASS: TestAccAzureRMIotHub_basic (409.36s)
--- PASS: TestAccAzureRMIotHub_customRoutes (463.73s)
--- PASS: TestAccAzureRMIotHub_withDifferentEndpointResourceGroup (582.51s)
PASS