Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use d.Get to set PRIVATE_EMPTY of azurerm_container_group #8151

Merged
merged 4 commits into from
Aug 24, 2020

Conversation

neil-yechenwei
Copy link
Contributor

fixes #8096

Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one minor comment but this otherwise LGTM

This is a behavioural change so it'll want calling out in the upgrade notes

@ghost ghost added the documentation label Aug 22, 2020
@neil-yechenwei
Copy link
Contributor Author

@tombuildsstuff , thanks for your suggestion. I've updated code by your comment. Please have a look. Thanks.

@tombuildsstuff tombuildsstuff added this to the v2.25.0 milestone Aug 24, 2020
@tombuildsstuff tombuildsstuff merged commit beb6b73 into hashicorp:master Aug 24, 2020
tombuildsstuff added a commit that referenced this pull request Aug 24, 2020
@ghost
Copy link

ghost commented Aug 27, 2020

This has been released in version 2.25.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.25.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Sep 23, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Sep 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
2 participants