Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Data Source: azurerm_servicebus_queue_authorization_rule #8438

Merged

Conversation

callumc46
Copy link
Contributor

Attempting to get functionality for the servicebus queue as a data source.

Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @callumc46, thanks for opening this PR. The datasource looks great but we'll need tests and docs before we can merge.

@callumc46
Copy link
Contributor Author

Hey @callumc46, thanks for opening this PR. The datasource looks great but we'll need tests and docs before we can merge.

Thanks mbfrahry, I'll get them sorted.

@ghost ghost removed the waiting-response label Sep 14, 2020
@callumc46
Copy link
Contributor Author

callum@callumc46:~/go/src/github.com/terraform-providers/terraform-provider-azurerm-1$ make testacc TEST=./azurerm/internal/services/servicebus/tests TESTARGS="-run='TestAccDataSourceAzureRMServiceBusQueueAuthorizationRule_basic'"
==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
==> Checking that acceptance test packages are used...
TF_ACC=1 go test ./azurerm/internal/services/servicebus/tests -v -run='TestAccDataSourceAzureRMServiceBusQueueAuthorizationRule_basic' -timeout 180m -ldflags="-X=github.com/terraform-providers/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN TestAccDataSourceAzureRMServiceBusQueueAuthorizationRule_basic
=== PAUSE TestAccDataSourceAzureRMServiceBusQueueAuthorizationRule_basic
=== CONT TestAccDataSourceAzureRMServiceBusQueueAuthorizationRule_basic
--- PASS: TestAccDataSourceAzureRMServiceBusQueueAuthorizationRule_basic (271.81s)
PASS
ok github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/servicebus/tests 271.836s

@ghost ghost added documentation size/L and removed size/M labels Sep 15, 2020
@callumc46
Copy link
Contributor Author

@mbfrahry hope thats enough now. Give me a shout if I've missed something else.

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @callumc46 - LGTM 🚀

@katbyte katbyte changed the title Adding servicebus queue data source authorization rule functionality New Data Source: azurerm_servicebus_queue_authorization_rule Sep 16, 2020
@katbyte katbyte added this to the v2.28.0 milestone Sep 16, 2020
@katbyte katbyte merged commit f19346d into hashicorp:master Sep 16, 2020
katbyte added a commit that referenced this pull request Sep 16, 2020
@callumc46 callumc46 deleted the add-data-source-servicebus-queue-authrule branch September 16, 2020 07:43
@ghost
Copy link

ghost commented Sep 17, 2020

This has been released in version 2.28.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.28.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Oct 16, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Oct 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants