New resource `azurerm_storage_sync_cloud_endpoint` #8540

yupwei68 · 2020-09-21T06:09:32Z

Extend: #7843

Totally there will be three resources:
azurerm_storage_sync
azurerm_storage_sync_group
azurerm_cloud_endpoint

=== RUN TestAccAzureRMCloudEndpoint_basic
=== PAUSE TestAccAzureRMCloudEndpoint_basic
=== CONT TestAccAzureRMCloudEndpoint_basic
--- PASS: TestAccAzureRMCloudEndpoint_basic (390.42s)
=== RUN TestAccAzureRMCloudEndpoint_requiresImport
=== PAUSE TestAccAzureRMCloudEndpoint_requiresImport
=== CONT TestAccAzureRMCloudEndpoint_requiresImport
--- PASS: TestAccAzureRMCloudEndpoint_requiresImport (400.43s)

tombuildsstuff

hi @yupwei68

Thanks for this PR - I've taken a look through and left some comments inline - if we can fix those up then we should be able to take another look through here.

Thanks!

azurerm/internal/services/storage/client/client.go

azurerm/internal/services/storage/parsers/id.go

azurerm/internal/services/storage/resource_arm_storage_sync_cloud_endpoint.go

azurerm/internal/services/storage/tests/resource_arm_storage_sync_cloud_endpoint_test.go

website/docs/r/storage_sync_cloud_endpoint.html.markdown

tombuildsstuff · 2020-09-22T17:28:32Z

website/docs/r/storage_sync_cloud_endpoint.html.markdown

+  storage_account_name = azurerm_storage_account.example.name
+  lifecycle {
+    ignore_changes = [
+      acl, metadata


we shouldn't be shipping this in examples - what extra configuration is necessary here?

There'll be a storage sync signature assigned to the metadata, which we could not get from the storage sync service. Could we just ignore the metadata?

And as for acl, it's assigned to the following when a cloud endpoint is created, However, in share definition, start and expiry is necessary and no empty string requested:

acl { id = "GhostedRecall" access_policy { permissions = "r" } }

I agree with tom, if we are ignoring changes we need to fix the resources so its not required.

Sure. Create a PR for the fix #8811

website/docs/r/storage_sync_cloud_endpoint.html.markdown

yupwei68 · 2020-09-24T03:25:14Z

Hi @tombuildsstuff Sorry for the mistakes made. Please continue reviewing.

azurerm/internal/services/storage/tests/resource_arm_storage_sync_cloud_endpoint_test.go

yupwei68 · 2020-10-09T02:53:07Z

Dependent on #8811.
=== RUN TestAccAzureRMStorageSyncCloudEndpoint_basic
=== PAUSE TestAccAzureRMStorageSyncCloudEndpoint_basic
=== CONT TestAccAzureRMStorageSyncCloudEndpoint_basic
--- PASS: TestAccAzureRMStorageSyncCloudEndpoint_basic (395.54s)
=== RUN TestAccAzureRMStorageSyncCloudEndpoint_requiresImport
=== PAUSE TestAccAzureRMStorageSyncCloudEndpoint_requiresImport
=== CONT TestAccAzureRMStorageSyncCloudEndpoint_requiresImport
--- PASS: TestAccAzureRMStorageSyncCloudEndpoint_requiresImport (411.75s)

katbyte

Thanks @yupwei68 - this looks good now, however it seems like some tests are failing:

=== CONT  TestAccAzureRMStorageSyncCloudEndpoint_requiresImport
    TestAccAzureRMStorageSyncCloudEndpoint_requiresImport: testing.go:684: Step 0 error: errors during apply:
        
        Error: waiting for Storage Sync Cloud Endpoint "acctest-CEP-201026174017620407" to be created: Code="MgmtStorageAccountAuthorizationFailed" Message="Unable to read specified storage account. Please check the permissions and try again after some time."
        
          on /opt/teamcity-agent/temp/buildTmp/tf-test115906221/main.tf line 38:
          (source code not available)
        
        
    TestAccAzureRMStorageSyncCloudEndpoint_basic: testing.go:684: Step 0 error: errors during apply:
        
        Error: waiting for Storage Sync Cloud Endpoint "acctest-CEP-201026174017617273" to be created: Code="MgmtStorageAccountAuthorizationFailed" Message="Unable to read specified storage account. Please check the permissions and try again after some time."
        
          on /opt/teamcity-agent/temp/buildTmp/tf-test146444038/main.tf line 38:
          (source code not available)
        
        
--- FAIL: TestAccAzureRMStorageSyncCloudEndpoint_requiresImport (751.91s)

azurerm/internal/services/storage/resource_arm_storage_sync_cloud_endpoint.go

website/docs/r/storage_sync_cloud_endpoint.html.markdown

yupwei68 · 2020-10-29T02:40:35Z

@katbyte Thanks for the comment. Sorry that I can not reproduce this error. Would you mind retrying?

=== RUN TestAccAzureRMStorageSyncCloudEndpoint_basic
=== PAUSE TestAccAzureRMStorageSyncCloudEndpoint_basic
=== CONT TestAccAzureRMStorageSyncCloudEndpoint_basic
--- PASS: TestAccAzureRMStorageSyncCloudEndpoint_basic (310.43s)
=== RUN TestAccAzureRMStorageSyncCloudEndpoint_requiresImport
=== PAUSE TestAccAzureRMStorageSyncCloudEndpoint_requiresImport
=== CONT TestAccAzureRMStorageSyncCloudEndpoint_requiresImport
--- PASS: TestAccAzureRMStorageSyncCloudEndpoint_requiresImport (327.15s)

yupwei68 · 2020-11-06T04:21:18Z

Hi @katbyte I've tried several times, I could not reproduce this error. Would you mind testing it again?

katbyte · 2020-11-06T18:34:13Z

I'm still getting this error 🤷‍♀️

[TestAccAzureRMStorageSyncCloudEndpoint_requiresImport] [Test Output]
=== RUN   TestAccAzureRMStorageSyncCloudEndpoint_requiresImport
=== PAUSE TestAccAzureRMStorageSyncCloudEndpoint_requiresImport
=== CONT  TestAccAzureRMStorageSyncCloudEndpoint_requiresImport
    TestAccAzureRMStorageSyncCloudEndpoint_requiresImport: testing.go:684: Step 0 error: errors during apply:
        
        Error: waiting for Storage Sync Cloud Endpoint "acctest-CEP-201106181015426014" to be created: Code="MgmtStorageAccountAuthorizationFailed" Message="Unable to read specified storage account. Please check the permissions and try again after some time."
        
          on /opt/teamcity-agent/temp/buildTmp/tf-test285242175/main.tf line 38:
          (source code not available)
        
        
    TestAccAzureRMStorageSyncCloudEndpoint_basic: testing.go:684: Step 0 error: errors during apply:
        
        Error: waiting for Storage Sync Cloud Endpoint "acctest-CEP-201106181015420295" to be created: Code="MgmtStorageAccountAuthorizationFailed" Message="Unable to read specified storage account. Please check the permissions and try again after some time."
        
          on /opt/teamcity-agent/temp/buildTmp/tf-test170012512/main.tf line 38:
          (source code not available)

you can see this in TC

katbyte · 2020-11-09T22:16:23Z

Thanks @yupwei68 - closer now! only one failure test, and its a different error:

Test Failed

------- Stdout: -------
=== RUN   TestAccAzureRMStorageSyncCloudEndpoint_requiresImport
=== PAUSE TestAccAzureRMStorageSyncCloudEndpoint_requiresImport
=== CONT  TestAccAzureRMStorageSyncCloudEndpoint_requiresImport
    TestAccAzureRMStorageSyncCloudEndpoint_requiresImport: testing.go:684: Step 0 error: errors during apply:
        
        Error: authorization.RoleAssignmentsClient#Get: Failure responding to request: StatusCode=404 -- Original Error: autorest/azure: Service returned an error. Status=404 Code="RoleAssignmentNotFound" Message="The role assignment 'd415abb9-cfec-579e-1469-4d41713e254e' is not found."
        
          on /opt/teamcity-agent/temp/buildTmp/tf-test370194010/m

yupwei68 · 2020-11-10T03:22:09Z

Thanks @katbyte . There is a role assignment, which is necessary if it's the first time your use "storage sync". I have added this into doc here. This could not be added into acctest, cause it'll fail if the role assignment already exists.
I assume acctests have passed in TC.

yupwei68 · 2020-11-23T02:09:32Z

I've merged the upstream master

yupwei68 · 2020-11-24T01:46:22Z

azurerm/internal/services/storage/resource_arm_storage_sync_cloud_endpoint.go

yupwei68 · 2020-11-26T08:18:28Z

Thanks for comments @katbyte . Please continue reviewing.

=== RUN TestAccAzureRMStorageSyncCloudEndpoint_basic
=== PAUSE TestAccAzureRMStorageSyncCloudEndpoint_basic
=== CONT TestAccAzureRMStorageSyncCloudEndpoint_basic
--- PASS: TestAccAzureRMStorageSyncCloudEndpoint_basic (302.73s)
=== RUN TestAccAzureRMStorageSyncCloudEndpoint_requiresImport
=== PAUSE TestAccAzureRMStorageSyncCloudEndpoint_requiresImport
=== CONT TestAccAzureRMStorageSyncCloudEndpoint_requiresImport
--- PASS: TestAccAzureRMStorageSyncCloudEndpoint_requiresImport (313.50s)

katbyte

Thanks @yupwei68 - LGTM 👍

katbyte · 2020-12-08T19:26:43Z

@yupwei68 - once we fix the merge conflict this should be good to merge

yupwei68 · 2020-12-09T03:07:57Z

Thanks for your comments @katbyte . Tests have passed. Please continue reviewing.

katbyte

THanks

ghost · 2020-12-10T20:26:32Z

This has been released in version 2.40.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.40.0"
}
# ... other configuration ...

ghost · 2021-01-09T14:50:19Z

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

yupwei68 added 2 commits September 21, 2020 12:11

update cloud endpoint

ed81898

add doc

ff53bdf

ghost added size/XL documentation labels Sep 21, 2020

tombuildsstuff self-assigned this Sep 21, 2020

tombuildsstuff suggested changes Sep 22, 2020

View reviewed changes

tombuildsstuff added new-resource service/storage waiting-response labels Sep 22, 2020

yupwei68 added 4 commits September 23, 2020 10:58

r1

cab776d

merge

f016886

update

64bc87e

fmt

d24437e

yupwei68 requested a review from tombuildsstuff September 24, 2020 03:24

ghost removed the waiting-response label Sep 24, 2020

katbyte requested changes Oct 2, 2020

View reviewed changes

azurerm/internal/services/storage/tests/resource_arm_storage_sync_cloud_endpoint_test.go Outdated Show resolved Hide resolved

katbyte added the waiting-response label Oct 2, 2020

update

e6b81bd

yupwei68 mentioned this pull request Oct 9, 2020

azurerm_storage_share set metadata Computed and set acl start and expiry Optional #8811

Merged

ghost removed the waiting-response label Oct 9, 2020

katbyte requested changes Oct 26, 2020

View reviewed changes

azurerm/internal/services/storage/resource_arm_storage_sync_cloud_endpoint.go Outdated Show resolved Hide resolved

website/docs/r/storage_sync_cloud_endpoint.html.markdown Show resolved Hide resolved

update

cbde352

yupwei68 requested a review from katbyte October 29, 2020 02:39

merge

d85bd12

update

48f7846

yupwei68 added 3 commits November 10, 2020 10:07

update

c14ac81

update

e8df3ce

update doc

ff6d843

update

d26ed4e

katbyte requested changes Nov 26, 2020

View reviewed changes

azurerm/internal/services/storage/resource_arm_storage_sync_cloud_endpoint.go Show resolved Hide resolved

yupwei68 added 2 commits November 26, 2020 14:54

update

4c9d802

update

54457a2

yupwei68 requested a review from katbyte November 26, 2020 08:18

katbyte approved these changes Dec 8, 2020

View reviewed changes

yupwei68 added 4 commits December 9, 2020 10:12

update

3e01f74

update

4a378d9

merge

7f4f738

update

00684d9

yupwei68 requested a review from katbyte December 9, 2020 03:08

katbyte approved these changes Dec 9, 2020

View reviewed changes

katbyte added this to the v2.40.0 milestone Dec 9, 2020

katbyte merged commit 7ac76b8 into hashicorp:master Dec 9, 2020

katbyte added a commit that referenced this pull request Dec 9, 2020

update CHANGELOG.md for #8540

64b0c05

ghost locked as resolved and limited conversation to collaborators Jan 9, 2021

yupwei68 deleted the wyp-sync-ce branch June 7, 2021 06:45

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New resource `azurerm_storage_sync_cloud_endpoint` #8540

New resource `azurerm_storage_sync_cloud_endpoint` #8540

yupwei68 commented Sep 21, 2020

tombuildsstuff left a comment

tombuildsstuff Sep 22, 2020

yupwei68 Sep 23, 2020

yupwei68 Sep 23, 2020

katbyte Oct 2, 2020

yupwei68 Oct 9, 2020

yupwei68 commented Sep 24, 2020

yupwei68 commented Oct 9, 2020

katbyte left a comment

yupwei68 commented Oct 29, 2020

yupwei68 commented Nov 6, 2020

katbyte commented Nov 6, 2020

katbyte commented Nov 9, 2020

yupwei68 commented Nov 10, 2020

yupwei68 commented Nov 23, 2020

yupwei68 commented Nov 24, 2020

yupwei68 commented Nov 26, 2020

katbyte left a comment

katbyte commented Dec 8, 2020

yupwei68 commented Dec 9, 2020

katbyte left a comment

ghost commented Dec 10, 2020

ghost commented Jan 9, 2021

New resource azurerm_storage_sync_cloud_endpoint #8540

New resource azurerm_storage_sync_cloud_endpoint #8540

Conversation

yupwei68 commented Sep 21, 2020

tombuildsstuff left a comment

Choose a reason for hiding this comment

tombuildsstuff Sep 22, 2020

Choose a reason for hiding this comment

yupwei68 Sep 23, 2020

Choose a reason for hiding this comment

yupwei68 Sep 23, 2020

Choose a reason for hiding this comment

katbyte Oct 2, 2020

Choose a reason for hiding this comment

yupwei68 Oct 9, 2020

Choose a reason for hiding this comment

yupwei68 commented Sep 24, 2020

yupwei68 commented Oct 9, 2020

katbyte left a comment

Choose a reason for hiding this comment

yupwei68 commented Oct 29, 2020

yupwei68 commented Nov 6, 2020

katbyte commented Nov 6, 2020

katbyte commented Nov 9, 2020

yupwei68 commented Nov 10, 2020

yupwei68 commented Nov 23, 2020

yupwei68 commented Nov 24, 2020

yupwei68 commented Nov 26, 2020

katbyte left a comment

Choose a reason for hiding this comment

katbyte commented Dec 8, 2020

yupwei68 commented Dec 9, 2020

katbyte left a comment

Choose a reason for hiding this comment

ghost commented Dec 10, 2020

ghost commented Jan 9, 2021

New resource `azurerm_storage_sync_cloud_endpoint` #8540

New resource `azurerm_storage_sync_cloud_endpoint` #8540