Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_app_service - allow v6 IPs for the webapp ip_restriction property #8599

Merged
merged 5 commits into from
Oct 2, 2020
Merged

azurerm_app_service - allow v6 IPs for the webapp ip_restriction property #8599

merged 5 commits into from
Oct 2, 2020

Conversation

andrey-dubnik
Copy link
Contributor

Should resolve #6423

@ghost ghost added the size/M label Sep 23, 2020
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @andrey-dubnik - i think the builtin validation.IsCIDR function should work for this? if so could we use it instead?

thanks!

azurerm/internal/services/web/app_service.go Outdated Show resolved Hide resolved
@andrey-dubnik
Copy link
Contributor Author

@katbyte any chance for PR to merge or still needs something?

@ghost ghost removed the waiting-response label Oct 2, 2020
@katbyte katbyte added this to the v2.31.0 milestone Oct 2, 2020
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @andrey-dubnik - just using the plugin SDK IsCIDR instead of writing on into the provider. I've pushed that change and am running the tests to get it merged shortly 🙂

@katbyte katbyte changed the title Enable ipv6 in the webapp ip_restriction azurerm_app_service - allow v6 IPs for the webapp ip_restriction property Oct 2, 2020
@katbyte katbyte merged commit a9324ef into hashicorp:master Oct 2, 2020
katbyte added a commit that referenced this pull request Oct 2, 2020
@ghost
Copy link

ghost commented Oct 8, 2020

This has been released in version 2.31.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.31.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Nov 2, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Nov 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot use ipv6 address as ip_restriction in azurerm_app_service
2 participants