New Service (Multiple Resources): DesktopVirtualization (Virtual Desktops) #8605

DanielMabbett · 2020-09-24T08:25:44Z

New Service: DesktopVirtualization (Virtual Desktops)

The following has been added following issue request:
#3507

The following has been added:

New folder for the new service DesktopVirtualization
Added the following resources for initial commit:
- azurerm_virtual_desktop_workspace
- azurerm_virtual_desktop_host_pool
- azurerm_virtual_desktop_application_group
- azurerm_virtual_desktop_workspace_application_group_association
Added basic tests for the resources above.

NOTE

This may not be complete with every feature DesktopVirtualization has, but would provide a solid base for us to add more resources in following releases.

…vider-azurerm

This reverts commit d398b20.

* init * add client.go. fix check test package sh * init add client + go mod addition * working client * initial work for virtual desktop workspace * init host pool resource * add host pool resource * add app group * add workspace application group association resource * update association tests * update app association and host pool * added documentation desktopvirtualization * Update virtual desktop resources * simpler error step for testing association

…rce_test.go

…azurerm

…vider-azurerm

…ll need to fix vendor issues

…vider-azurerm

katbyte

Thank you for the PR @DanielMabbett,

Overall this is off to a great start! I've gone over it and left some comments inline but some of the main points are:

regardless of what the SDK/api calls a property we tend to use a name that makes the most sense. I've left some suggestions inline
each resource should have a complete test that sets all properties and an update test that goes basic -> complete -> basic
all properties should be set on a read for each resource
moving the test files up one directory into the service package

Once these are addressed this should be good to merge

...rnal/services/desktopvirtualization/tests/virtual_desktop_application_group_resource_test.go

...erm/internal/services/desktopvirtualization/tests/virtual_desktop_host_pool_resource_test.go

azurerm/internal/services/desktopvirtualization/virtual_desktop_workspace_resource.go

website/docs/r/virtual_desktop_application_group.html.markdown

...rnal/services/desktopvirtualization/tests/virtual_desktop_application_group_resource_test.go

...erm/internal/services/desktopvirtualization/tests/virtual_desktop_host_pool_resource_test.go

Co-authored-by: kt <kt@katbyte.me>

…desktop_application_group_resource_test.go Co-authored-by: kt <kt@katbyte.me>

…desktop_host_pool_resource_test.go Co-authored-by: kt <kt@katbyte.me>

…desktop_workspace_resource_test.go Co-authored-by: kt <kt@katbyte.me>

…azurerm

DanielMabbett · 2020-09-29T16:00:18Z

Still need to do some more clean up. Should be done in the next day or two.

katbyte

Thanks for those changes! I've given this another pass and most of my comments are fairly minor this time. Look forward to getting this into 2.31!

azurerm/internal/services/desktopvirtualization/virtual_desktop_application_group_resource.go

azurerm/internal/services/desktopvirtualization/virtual_desktop_host_pool_resource.go

azurerm/internal/services/desktopvirtualization/virtual_desktop_host_pool_resource_test.go

...m/internal/services/desktopvirtualization/virtual_desktop_application_group_resource_test.go

...es/desktopvirtualization/virtual_desktop_workspace_application_group_association_resource.go

azurerm/internal/services/desktopvirtualization/virtual_desktop_workspace_resource_test.go

website/docs/r/virtual_desktop_workspace.html.markdown

Co-authored-by: kt <kt@katbyte.me>

…p_workspace_resource_test.go Co-authored-by: kt <kt@katbyte.me>

…p_application_group_resource_test.go Co-authored-by: kt <kt@katbyte.me>

…p_host_pool_resource_test.go Co-authored-by: kt <kt@katbyte.me>

…p_application_group_resource.go Co-authored-by: kt <kt@katbyte.me>

…p_host_pool_resource.go Co-authored-by: kt <kt@katbyte.me>

…ence_id to application_group_id

DanielMabbett · 2020-10-05T09:32:00Z

Ready for another review :)

…vider-azurerm

katbyte

thanks @DanielMabbett - aside from a few minor comments while i will apply inline this LGTM 👍

azurerm/internal/services/desktopvirtualization/virtual_desktop_workspace_resource_test.go

...sktopvirtualization/virtual_desktop_workspace_application_group_association_resource_test.go

website/docs/r/virtual_desktop_workspace_application_group_association.html.markdown

…p_workspace_resource_test.go

…ociation.html.markdown

…p_workspace_application_group_association_resource_test.go

ghost · 2020-10-08T18:53:40Z

This has been released in version 2.31.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.31.0"
}
# ... other configuration ...

ghost · 2020-11-07T14:50:48Z

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

DanielMabbett added 10 commits September 23, 2020 15:23

Merge branch 'master' of github.com:terraform-providers/terraform-pro…

c6c1c7b

…vider-azurerm

Revert "Update check-test-package.sh"

703d98e

This reverts commit d398b20.

Update network_interface_application_security_group_association_resou…

6fc34f9

…rce_test.go

Update check-test-package.sh

d398b20

Merge branch 'master' of github.com:DanielMabbett/terraform-provider-…

25f26bc

…azurerm

Merge branch 'master' of github.com:terraform-providers/terraform-pro…

e93e09f

…vider-azurerm

Revert test package back to original

76f267e

fix documentation association

e03158b

Fixed linting issues and documentation terraform code formatting. Sti…

2863b60

…ll need to fix vendor issues

ghost added size/XXL dependencies labels Sep 24, 2020

DanielMabbett added 3 commits September 28, 2020 17:24

move test files and remove multiline comment

ef590e7

cleanup

2d48cf3

Merge branch 'master' of github.com:terraform-providers/terraform-pro…

8e536f0

…vider-azurerm

katbyte requested changes Sep 28, 2020

View reviewed changes

katbyte added new-resource service/virtual-desktops labels Sep 28, 2020

katbyte modified the milestone: v2.30.0 Sep 28, 2020

katbyte added the waiting-response label Sep 29, 2020

DanielMabbett and others added 5 commits September 29, 2020 09:15

Update website/docs/r/virtual_desktop_application_group.html.markdown

4150d55

Co-authored-by: kt <kt@katbyte.me>

Update azurerm/internal/services/desktopvirtualization/tests/virtual_…

5097261

…desktop_application_group_resource_test.go Co-authored-by: kt <kt@katbyte.me>

Update azurerm/internal/services/desktopvirtualization/tests/virtual_…

7e580d7

…desktop_host_pool_resource_test.go Co-authored-by: kt <kt@katbyte.me>

Update azurerm/internal/services/desktopvirtualization/tests/virtual_…

8d31970

…desktop_workspace_resource_test.go Co-authored-by: kt <kt@katbyte.me>

Merge branch 'master' of github.com:DanielMabbett/terraform-provider-…

84dbbb6

…azurerm

ghost removed the waiting-response label Sep 29, 2020

DanielMabbett added 2 commits October 2, 2020 15:27

cleanup + move to latest sdk api version + website build

998622b

hotfix documentation should be "Pooled" for host pool

095e69d

katbyte requested changes Oct 3, 2020

View reviewed changes

katbyte added the waiting-response label Oct 3, 2020

katbyte added this to the v2.31.0 milestone Oct 3, 2020

DanielMabbett and others added 9 commits October 3, 2020 22:12

Update website/docs/r/virtual_desktop_workspace.html.markdown

d745ac7

Co-authored-by: kt <kt@katbyte.me>

Update azurerm/internal/services/desktopvirtualization/virtual_deskto…

562554f

…p_workspace_resource_test.go Co-authored-by: kt <kt@katbyte.me>

Update azurerm/internal/services/desktopvirtualization/virtual_deskto…

8ed1a6f

…p_workspace_resource_test.go Co-authored-by: kt <kt@katbyte.me>

Update azurerm/internal/services/desktopvirtualization/virtual_deskto…

2acecf6

…p_application_group_resource_test.go Co-authored-by: kt <kt@katbyte.me>

Update azurerm/internal/services/desktopvirtualization/virtual_deskto…

bb2582f

…p_host_pool_resource_test.go Co-authored-by: kt <kt@katbyte.me>

Update azurerm/internal/services/desktopvirtualization/virtual_deskto…

2ef0902

…p_application_group_resource.go Co-authored-by: kt <kt@katbyte.me>

Update azurerm/internal/services/desktopvirtualization/virtual_deskto…

06d83da

…p_host_pool_resource.go Co-authored-by: kt <kt@katbyte.me>

update/move function to utils. Change name of application_group_refer…

6d7dd26

…ence_id to application_group_id

CI fixes

4a4f2e8

DanielMabbett requested a review from katbyte October 4, 2020 19:46

ghost removed the waiting-response label Oct 5, 2020

DanielMabbett added 2 commits October 6, 2020 19:45

Merge branch 'master' of github.com:terraform-providers/terraform-pro…

758a081

…vider-azurerm

fix failing tests for wvd resources

6745e6b

katbyte approved these changes Oct 7, 2020

View reviewed changes

katbyte added 4 commits October 7, 2020 16:02

Update azurerm/internal/services/desktopvirtualization/virtual_deskto…

adb663d

…p_workspace_resource_test.go

Update azurerm/internal/services/desktopvirtualization/virtual_deskto…

563564c

…p_workspace_resource_test.go

Update website/docs/r/virtual_desktop_workspace_application_group_ass…

d557180

…ociation.html.markdown

Update azurerm/internal/services/desktopvirtualization/virtual_deskto…

a3a96ac

…p_workspace_application_group_association_resource_test.go

katbyte merged commit b39d2ed into hashicorp:master Oct 7, 2020

katbyte added a commit that referenced this pull request Oct 7, 2020

update CHANGELOG>md for #8605

44a5723

alexwilcox9 mentioned this pull request Oct 8, 2020

Support for WVD Hostpool RDP Properties #8800

Closed

ghost mentioned this pull request Oct 13, 2020

Azure Windows Virtual Desktop: Unsupported argument "validation_environment" #8862

Closed

rmunilla mentioned this pull request Nov 3, 2020

WVD Hostpool name length more than 24 characters #9138

Open

ghost locked as resolved and limited conversation to collaborators Nov 7, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New Service (Multiple Resources): DesktopVirtualization (Virtual Desktops) #8605

New Service (Multiple Resources): DesktopVirtualization (Virtual Desktops) #8605

DanielMabbett commented Sep 24, 2020 •

edited

Loading

katbyte left a comment

DanielMabbett commented Sep 29, 2020

katbyte left a comment

DanielMabbett commented Oct 5, 2020

katbyte left a comment

ghost commented Oct 8, 2020

ghost commented Nov 7, 2020

New Service (Multiple Resources): DesktopVirtualization (Virtual Desktops) #8605

New Service (Multiple Resources): DesktopVirtualization (Virtual Desktops) #8605

Conversation

DanielMabbett commented Sep 24, 2020 • edited Loading

New Service: DesktopVirtualization (Virtual Desktops)

NOTE

katbyte left a comment

Choose a reason for hiding this comment

DanielMabbett commented Sep 29, 2020

katbyte left a comment

Choose a reason for hiding this comment

DanielMabbett commented Oct 5, 2020

katbyte left a comment

Choose a reason for hiding this comment

ghost commented Oct 8, 2020

ghost commented Nov 7, 2020

DanielMabbett commented Sep 24, 2020 •

edited

Loading