Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate Service Bus Topic and Queue max_size_in_megabytes #8648

Merged
merged 1 commit into from
Sep 28, 2020
Merged

Validate Service Bus Topic and Queue max_size_in_megabytes #8648

merged 1 commit into from
Sep 28, 2020

Conversation

marc-sensenich
Copy link
Contributor

@marc-sensenich marc-sensenich commented Sep 27, 2020

Adds validation for max_size_in_megabytes for Azure Service Bus Topics and Queues

Acceptance test status for affected resources as of 2f87399

--- PASS: TestAccAzureRMServiceBusQueue_requiresImport (231.63s)
--- PASS: TestAccAzureRMServiceBusQueue_enableDuplicateDetection (245.76s)
--- PASS: TestAccAzureRMServiceBusQueue_forwardDeadLetteredMessagesTo (247.14s)
--- PASS: TestAccAzureRMServiceBusQueue_enablePartitioningStandard (259.15s)
--- PASS: TestAccAzureRMServiceBusQueue_lockDuration (259.69s)
--- PASS: TestAccAzureRMServiceBusQueueAuthorizationRule_listen (269.16s)
--- PASS: TestAccAzureRMServiceBusQueue_update (457.01s)
--- PASS: TestAccAzureRMServiceBusQueue_maxDeliveryCount (238.92s)
--- PASS: TestAccAzureRMServiceBusQueue_enableDeadLetteringOnMessageExpiration (216.99s)
--- PASS: TestAccAzureRMServiceBusQueue_forwardTo (230.92s)
--- PASS: TestAccAzureRMServiceBusQueue_isoTimeSpanAttributes (245.28s)
--- PASS: TestAccAzureRMServiceBusQueue_defaultEnablePartitioningPremium (542.16s)
--- PASS: TestAccAzureRMServiceBusQueueAuthorizationRule_listensend (207.65s)
--- PASS: TestAccAzureRMServiceBusQueueAuthorizationRule_send (203.68s)
--- PASS: TestAccAzureRMServiceBusQueueAuthorizationRule_manage (214.54s)
--- PASS: TestAccAzureRMServiceBusQueue_status (456.61s)
--- PASS: TestAccAzureRMServiceBusQueueAuthorizationRule_requiresImport (237.50s)
--- PASS: TestAccAzureRMServiceBusQueue_enableRequiresSession (227.47s)
--- PASS: TestAccAzureRMServiceBusQueueAuthorizationRule_rightsUpdate (465.94s)
--- PASS: TestAccAzureRMServiceBusQueue_basic (209.26s)
--- PASS: TestAccAzureRMServiceBusTopic_basicDisabled (212.18s)
--- PASS: TestAccAzureRMServiceBusTopic_update (222.37s)
--- PASS: TestAccAzureRMServiceBusTopic_enableDuplicateDetection (227.93s)
--- PASS: TestAccAzureRMServiceBusTopic_enablePartitioningStandard (252.15s)
--- PASS: TestAccAzureRMServiceBusTopicAuthorizationRule_requiresImport (253.03s)
--- PASS: TestAccAzureRMServiceBusTopic_requiresImport (206.99s)
--- PASS: TestAccAzureRMServiceBusTopicAuthorizationRule_listen (420.27s)
--- PASS: TestAccAzureRMServiceBusTopic_isoTimeSpanAttributes (421.30s)
--- PASS: TestAccAzureRMServiceBusTopic_basic (216.77s)
--- PASS: TestAccAzureRMServiceBusTopicAuthorizationRule_listensend (188.62s)
--- PASS: TestAccAzureRMServiceBusTopicAuthorizationRule_rightsUpdate (228.80s)
--- PASS: TestAccAzureRMServiceBusTopic_basicDisableEnable (225.88s)
--- PASS: TestAccAzureRMServiceBusTopic_enablePartitioningPremium (565.39s)
--- PASS: TestAccAzureRMServiceBusTopicAuthorizationRule_manage (201.87s)
--- PASS: TestAccAzureRMServiceBusTopicAuthorizationRule_send (217.74s)

@ghost ghost added the size/S label Sep 27, 2020
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @marc-sensenich - LGTM 👍

@katbyte katbyte added this to the v2.30.0 milestone Sep 28, 2020
@katbyte katbyte merged commit 6575e44 into hashicorp:master Sep 28, 2020
katbyte added a commit that referenced this pull request Sep 28, 2020
@ghost
Copy link

ghost commented Oct 1, 2020

This has been released in version 2.30.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.30.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Oct 28, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Oct 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants