-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
azurerm_cosmosdb_mongo_database
doesn't call get throughput api when cosmos account is serverless
#8673
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aside from one comment this LGTM 👍
azurerm/internal/services/cosmos/cosmosdb_mongo_database_resource.go
Outdated
Show resolved
Hide resolved
@katbyte Thanks for your comments. Please continue reviewing. |
Hi @yupwei68 Which region/location are you running this test in? It fails on the test suite with:
|
Hi @jackofallops Previously it worked. Currently I've updated the acctest to get it passed with mongo version 3.6. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for addressing the comments / changes @yupwei68 - LGTM now 👍
This has been released in version 2.35.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 2.35.0"
}
# ... other configuration ... |
Hi, the same issue exists for azurerm_cosmosdb_sql_database |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
Fix #8661
=== RUN TestAccAzureRMCosmosDbMongoDatabase_basic
=== PAUSE TestAccAzureRMCosmosDbMongoDatabase_basic
=== CONT TestAccAzureRMCosmosDbMongoDatabase_basic
--- PASS: TestAccAzureRMCosmosDbMongoDatabase_basic (1726.68s)
=== RUN TestAccAzureRMCosmosDbMongoDatabase_complete
=== PAUSE TestAccAzureRMCosmosDbMongoDatabase_complete
=== CONT TestAccAzureRMCosmosDbMongoDatabase_complete
--- PASS: TestAccAzureRMCosmosDbMongoDatabase_complete (1794.50s)
=== RUN TestAccAzureRMCosmosDbMongoDatabase_autoscale
=== PAUSE TestAccAzureRMCosmosDbMongoDatabase_autoscale
=== CONT TestAccAzureRMCosmosDbMongoDatabase_autoscale
--- PASS: TestAccAzureRMCosmosDbMongoDatabase_autoscale (2084.84s)
=== RUN TestAccAzureRMCosmosDbMongoDatabase_serverless
=== PAUSE TestAccAzureRMCosmosDbMongoDatabase_serverless
=== CONT TestAccAzureRMCosmosDbMongoDatabase_serverless
--- PASS: TestAccAzureRMCosmosDbMongoDatabase_serverless (1724.47s)