-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ignore_changes behavior for AGW #8761
Conversation
this looks good, but I would like to see a test. That's what was keeping me from PRing. |
@ztbrown Will try to do it today or tomorrow |
@ztbrown Was you thinking about unit tests OR manual testing of this change? |
unit / acceptance was what I was thinking |
@ztbrown I created a draft of unit test that should work for us. For now, I need to find a way how to change AGW certificate via Go code, after that it could be seen as a whole change. |
} | ||
|
||
return nil | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove this newline
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this is what is upsetting the linter.
@ztbrown I've seen and will fix it a little bit later. For now, I'm not able to fix my test, have the following issue:
Do you have any idea why |
@ztbrown probably I finished with tests. For now I need to find a way of fixing linter issues and after that it could be reviewed and merged |
👍 Looking great! |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @kvendingoldo - This LGTM 👍
Tests Passing:
This has been released in version 2.33.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 2.33.0"
}
# ... other configuration ... |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
No description provided.