`azurerm_app_configuration` - add support for identity #8875

favoretti · 2020-10-13T20:13:36Z

Adding support for identity to azurerm_app_configuration.

favoretti · 2020-10-13T20:17:00Z

Acceptance tests pass:

$ TF_ACC=1 go test -v ./azurerm/internal/services/appconfiguration/tests -timeout=600m
=== RUN   TestAccAppConfigurationDataSource_basic
=== PAUSE TestAccAppConfigurationDataSource_basic
=== RUN   TestAccAppConfigurationResource_free
=== PAUSE TestAccAppConfigurationResource_free
=== RUN   TestAccAppConfigurationResource_standard
=== PAUSE TestAccAppConfigurationResource_standard
=== RUN   TestAccAppConfigurationResource_requiresImport
=== PAUSE TestAccAppConfigurationResource_requiresImport
=== RUN   TestAccAppConfigurationResource_complete
=== PAUSE TestAccAppConfigurationResource_complete
=== RUN   TestAccAppConfigurationResource_identity
=== PAUSE TestAccAppConfigurationResource_identity
=== RUN   TestAccAppConfigurationResource_update
=== PAUSE TestAccAppConfigurationResource_update
=== CONT  TestAccAppConfigurationDataSource_basic
=== CONT  TestAccAppConfigurationResource_complete
=== CONT  TestAccAppConfigurationResource_update
=== CONT  TestAccAppConfigurationResource_standard
=== CONT  TestAccAppConfigurationResource_requiresImport
=== CONT  TestAccAppConfigurationResource_identity
=== CONT  TestAccAppConfigurationResource_free
--- PASS: TestAccAppConfigurationResource_free (87.13s)
--- PASS: TestAccAppConfigurationResource_complete (91.11s)
--- PASS: TestAccAppConfigurationResource_standard (91.12s)
--- PASS: TestAccAppConfigurationResource_identity (94.64s)
--- PASS: TestAccAppConfigurationResource_requiresImport (96.07s)
--- PASS: TestAccAppConfigurationResource_update (107.52s)
--- PASS: TestAccAppConfigurationDataSource_basic (113.66s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/appconfiguration/tests	114.840s

ArcturusZhang

Hi @favoretti thanks for this PR! Looking good so far, but I assume since this identity block is optional, could we add some more tests to test the update behaviour of the identity?
For instance, a test from no identity to systemAssigned identity and then back to no identity to confirm the identity block could be properly updated.

favoretti · 2020-10-15T09:09:31Z

@ArcturusZhang Something like commit below?

$ TF_ACC=1 go test -v ./azurerm/internal/services/appconfiguration/tests -timeout=600m
=== RUN   TestAccAppConfigurationDataSource_basic
=== PAUSE TestAccAppConfigurationDataSource_basic
=== RUN   TestAccAppConfigurationResource_free
=== PAUSE TestAccAppConfigurationResource_free
=== RUN   TestAccAppConfigurationResource_standard
=== PAUSE TestAccAppConfigurationResource_standard
=== RUN   TestAccAppConfigurationResource_requiresImport
=== PAUSE TestAccAppConfigurationResource_requiresImport
=== RUN   TestAccAppConfigurationResource_complete
=== PAUSE TestAccAppConfigurationResource_complete
=== RUN   TestAccAppConfigurationResource_identity
=== PAUSE TestAccAppConfigurationResource_identity
=== RUN   TestAccAppConfigurationResource_identityUpdated
=== PAUSE TestAccAppConfigurationResource_identityUpdated
=== RUN   TestAccAppConfigurationResource_update
=== PAUSE TestAccAppConfigurationResource_update
=== CONT  TestAccAppConfigurationDataSource_basic
=== CONT  TestAccAppConfigurationResource_complete
=== CONT  TestAccAppConfigurationResource_identity
=== CONT  TestAccAppConfigurationResource_identityUpdated
=== CONT  TestAccAppConfigurationResource_update
=== CONT  TestAccAppConfigurationResource_standard
=== CONT  TestAccAppConfigurationResource_free
=== CONT  TestAccAppConfigurationResource_requiresImport
--- PASS: TestAccAppConfigurationResource_standard (91.21s)
--- PASS: TestAccAppConfigurationResource_free (91.26s)
--- PASS: TestAccAppConfigurationResource_complete (92.40s)
--- PASS: TestAccAppConfigurationResource_identity (92.67s)
--- PASS: TestAccAppConfigurationResource_requiresImport (94.91s)
--- PASS: TestAccAppConfigurationResource_update (107.08s)
--- PASS: TestAccAppConfigurationDataSource_basic (107.12s)
--- PASS: TestAccAppConfigurationResource_identityUpdated (132.16s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/appconfiguration/tests	133.243s

favoretti · 2020-10-15T09:16:01Z

Adjusted the test to actually check for identity being present.

ArcturusZhang

Hi @favoretti thanks for the revision! I just left some minor comments. And out of curiosity, the SDK supports more values of enum type IdentityType actually, would we also support those other types of identity (such as UserAssignedIdentity)? But it should be fine if we only add the SystemAssigned identity in this PR for now.

azurerm/internal/services/appconfiguration/app_configuration_resource.go

…esource.go Co-authored-by: Arcturus <ufo54153@gmail.com>

favoretti · 2020-10-16T09:18:19Z

Re: UserAssigned identities - those are a bit more complex and SystemAssigned is what we currently need support for, so in the interest of time getting this in I decided to implement just SystemAssigned. Happy to work on UserAssigned in a separate PR. Sorry for being selfish, time is precious unfortunately, so contributing the bare minimum needs atm :(

ArcturusZhang

LGTM now, thanks @favoretti ! And it is very fine that we could get the user assigned identity supported in another PR.

tombuildsstuff

hey @favoretti

Thanks for pushing those changes - taking a look through this is mostly looking good, if we can fix up the couple of comments then this should otherwise be good to merge 👍

Thanks!

azurerm/internal/services/appconfiguration/app_configuration_resource.go

azurerm/internal/services/appconfiguration/tests/app_configuration_resource_test.go

…esource.go Co-authored-by: Tom Harvey <tombuildsstuff@users.noreply.github.com>

tombuildsstuff

left a couple of comments inline

azurerm/internal/services/appconfiguration/app_configuration_resource.go

favoretti · 2020-10-19T13:55:38Z

"Fixed" it by sending payload with identity type None when clearing.

$ TF_ACC=1 go test -v ./azurerm/internal/services/appconfiguration/tests -timeout=600m -run=TestAccAppConfigurationResource_identityUpdated
=== RUN   TestAccAppConfigurationResource_identityUpdated
=== PAUSE TestAccAppConfigurationResource_identityUpdated
=== CONT  TestAccAppConfigurationResource_identityUpdated
--- PASS: TestAccAppConfigurationResource_identityUpdated (148.10s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/appconfiguration/tests	149.290s

tombuildsstuff

otherwise LGTM 👍

azurerm/internal/services/appconfiguration/app_configuration_resource.go

favoretti · 2020-10-20T07:54:23Z

Yep, you're right, works :)

$ TF_ACC=1 go test -v ./azurerm/internal/services/appconfiguration/tests -timeout=600m -run=TestAccAppConfigurationResource_identityUpdated
=== RUN   TestAccAppConfigurationResource_identityUpdated
=== PAUSE TestAccAppConfigurationResource_identityUpdated
=== CONT  TestAccAppConfigurationResource_identityUpdated
--- PASS: TestAccAppConfigurationResource_identityUpdated (147.64s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/appconfiguration/tests	148.858s

tombuildsstuff · 2020-10-20T08:52:05Z

Thanks for pushing those changes @favoretti 👍

ghost · 2020-10-22T15:58:11Z

This has been released in version 2.33.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.33.0"
}
# ... other configuration ...

ghost · 2020-11-19T14:50:00Z

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

- add support for identity

2cd51ec

ghost added size/M documentation labels Oct 13, 2020

Switch identity test to standard sku

0496446

ArcturusZhang suggested changes Oct 15, 2020

View reviewed changes

Add more tests

f6a37a4

ghost added size/L and removed size/M labels Oct 15, 2020

Actually check for identity present

e1d4f1a

ArcturusZhang suggested changes Oct 16, 2020

View reviewed changes

favoretti and others added 6 commits October 16, 2020 10:59

Update azurerm/internal/services/appconfiguration/app_configuration_r…

de7c378

…esource.go Co-authored-by: Arcturus <ufo54153@gmail.com>

Update azurerm/internal/services/appconfiguration/app_configuration_r…

4f91446

…esource.go Co-authored-by: Arcturus <ufo54153@gmail.com>

Update azurerm/internal/services/appconfiguration/app_configuration_r…

2242dbb

…esource.go Co-authored-by: Arcturus <ufo54153@gmail.com>

Update azurerm/internal/services/appconfiguration/app_configuration_r…

5e50dc6

…esource.go Co-authored-by: Arcturus <ufo54153@gmail.com>

Update azurerm/internal/services/appconfiguration/app_configuration_r…

01cd721

…esource.go Co-authored-by: Arcturus <ufo54153@gmail.com>

Fix the fixes. Eeturn empty identity block?

aeae2da

favoretti requested a review from ArcturusZhang October 16, 2020 09:16

ArcturusZhang approved these changes Oct 19, 2020

View reviewed changes

tombuildsstuff suggested changes Oct 19, 2020

View reviewed changes

azurerm/internal/services/appconfiguration/app_configuration_resource.go Show resolved Hide resolved

azurerm/internal/services/appconfiguration/tests/app_configuration_resource_test.go Outdated Show resolved Hide resolved

tombuildsstuff added enhancement service/app-configuration waiting-response labels Oct 19, 2020

tombuildsstuff added this to the v2.33.0 milestone Oct 19, 2020

favoretti and others added 2 commits October 19, 2020 09:50

Update azurerm/internal/services/appconfiguration/app_configuration_r…

65a2726

…esource.go Co-authored-by: Tom Harvey <tombuildsstuff@users.noreply.github.com>

Fix the fix

95ecbb3

tombuildsstuff suggested changes Oct 19, 2020

View reviewed changes

azurerm/internal/services/appconfiguration/app_configuration_resource.go Outdated Show resolved Hide resolved

azurerm/internal/services/appconfiguration/app_configuration_resource.go Outdated Show resolved Hide resolved

favoretti added 2 commits October 19, 2020 12:59

Remove unused code from flatten

b7fc1a0

Send identity type None when clearing it, since API wants it that way

b30f1e0

ghost removed the waiting-response label Oct 19, 2020

favoretti requested a review from tombuildsstuff October 19, 2020 13:55

tombuildsstuff approved these changes Oct 20, 2020

View reviewed changes

azurerm/internal/services/appconfiguration/app_configuration_resource.go Outdated Show resolved Hide resolved

azurerm/internal/services/appconfiguration/app_configuration_resource.go Show resolved Hide resolved

tombuildsstuff added the waiting-response label Oct 20, 2020

Simplify identity handling

f492793

ghost removed the waiting-response label Oct 20, 2020

tombuildsstuff merged commit 8d05c28 into hashicorp:master Oct 20, 2020

tombuildsstuff added a commit that referenced this pull request Oct 20, 2020

updating to include #8875

6a3e689

ghost locked as resolved and limited conversation to collaborators Nov 19, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

`azurerm_app_configuration` - add support for identity #8875

`azurerm_app_configuration` - add support for identity #8875

favoretti commented Oct 13, 2020

favoretti commented Oct 13, 2020

ArcturusZhang left a comment

favoretti commented Oct 15, 2020 •

edited

Loading

favoretti commented Oct 15, 2020

ArcturusZhang left a comment

favoretti commented Oct 16, 2020

ArcturusZhang left a comment

tombuildsstuff left a comment

tombuildsstuff left a comment

favoretti commented Oct 19, 2020

tombuildsstuff left a comment

favoretti commented Oct 20, 2020

tombuildsstuff commented Oct 20, 2020

ghost commented Oct 22, 2020

ghost commented Nov 19, 2020

azurerm_app_configuration - add support for identity #8875

azurerm_app_configuration - add support for identity #8875

Conversation

favoretti commented Oct 13, 2020

favoretti commented Oct 13, 2020

ArcturusZhang left a comment

Choose a reason for hiding this comment

favoretti commented Oct 15, 2020 • edited Loading

favoretti commented Oct 15, 2020

ArcturusZhang left a comment

Choose a reason for hiding this comment

favoretti commented Oct 16, 2020

ArcturusZhang left a comment

Choose a reason for hiding this comment

tombuildsstuff left a comment

Choose a reason for hiding this comment

tombuildsstuff left a comment

Choose a reason for hiding this comment

favoretti commented Oct 19, 2020

tombuildsstuff left a comment

Choose a reason for hiding this comment

favoretti commented Oct 20, 2020

tombuildsstuff commented Oct 20, 2020

ghost commented Oct 22, 2020

ghost commented Nov 19, 2020

`azurerm_app_configuration` - add support for identity #8875

`azurerm_app_configuration` - add support for identity #8875

favoretti commented Oct 15, 2020 •

edited

Loading