-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New resource/ data source azurerm_storage_encryption_scope
#8894
Conversation
I've merged the master branch. Please continue reviewing. |
Looks like this also requires changes to Giovanni to support the BlobEncryptionScope to be able to test this end-to-end: https://docs.microsoft.com/en-us/rest/api/storageservices/put-block |
…AccountId to match other resources
be78caa
to
57c1917
Compare
For now it looks like we should be able to ship this without the Blob and Containers support, but that'll require work in both the Giovanni SDK and (subsequently) those resources to support Encryption Scopes on those resources. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aside from one cOmment LGTM 👍
azurerm/internal/services/storage/resource_arm_storage_encryption_scope.go
Outdated
Show resolved
Hide resolved
This has been released in version 2.37.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 2.37.0"
}
# ... other configuration ... |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
Fix #8893
=== RUN TestAccAzureRMStorageEncryptionScope_basic
=== PAUSE TestAccAzureRMStorageEncryptionScope_basic
=== CONT TestAccAzureRMStorageEncryptionScope_basic
--- PASS: TestAccAzureRMStorageEncryptionScope_basic (136.38s)
=== RUN TestAccAzureRMStorageEncryptionScope_requiresImport
=== PAUSE TestAccAzureRMStorageEncryptionScope_requiresImport
=== CONT TestAccAzureRMStorageEncryptionScope_requiresImport
--- PASS: TestAccAzureRMStorageEncryptionScope_requiresImport (146.85s)
=== RUN TestAccAzureRMStorageEncryptionScope_completeSourceStorage
=== PAUSE TestAccAzureRMStorageEncryptionScope_completeSourceStorage
=== CONT TestAccAzureRMStorageEncryptionScope_completeSourceStorage
--- PASS: TestAccAzureRMStorageEncryptionScope_completeSourceStorage (136.50s)
=== RUN TestAccAzureRMStorageEncryptionScope_completeSourceKeyVault
=== PAUSE TestAccAzureRMStorageEncryptionScope_completeSourceKeyVault
=== CONT TestAccAzureRMStorageEncryptionScope_completeSourceKeyVault
--- PASS: TestAccAzureRMStorageEncryptionScope_completeSourceKeyVault (294.01s)
=== RUN TestAccAzureRMStorageEncryptionScope_update
=== PAUSE TestAccAzureRMStorageEncryptionScope_update
=== CONT TestAccAzureRMStorageEncryptionScope_update
--- PASS: TestAccAzureRMStorageEncryptionScope_update (493.35s)
=== RUN TestAccDataSourceAzureRMStorageEncryptionScope_basic
=== PAUSE TestAccDataSourceAzureRMStorageEncryptionScope_basic
=== CONT TestAccDataSourceAzureRMStorageEncryptionScope_basic
--- PASS: TestAccDataSourceAzureRMStorageEncryptionScope_basic (140.63s)