Add new resource azurerm_virtual_hub_route_table #8939
Conversation
There was a problem hiding this comment.
Thanks @neil-yechenwei - i've left some comments inline that need to be addressed before merge
|
|
||
| * `next_hop` - (Required) The next hop resource ID. | ||
|
|
||
| * `next_hop_type` - (Required) The type of next hop. Possible value is `ResourceId`. |
There was a problem hiding this comment.
| * `next_hop_type` - (Required) The type of next hop. Possible value is `ResourceId`. | |
| * `next_hop_type` - (Required) The type of next hop. Currently the only possible value is `ResourceId`. |
|
|
||
| * `name` - (Required) The name which should be used for this route. | ||
|
|
||
| * `destinations` - (Required) The list of all destinations. |
There was a problem hiding this comment.
could we elaborate this description
| }, | ||
| }, | ||
|
|
||
| "destination_type": { |
There was a problem hiding this comment.
this would make more sense as
| "destination_type": { | |
| "destinations_type": { |
as it applies to all of them
|
@katbyte , thanks for your comments. I've updated code. Please have a look. Thanks. |
There was a problem hiding this comment.
Thanks @neil-yechenwei, i've given this another review and left some more comments inline.
| ), | ||
| }, | ||
| data.ImportStep(), | ||
| }, |
There was a problem hiding this comment.
could we add another step going back to basic here?
| } | ||
|
|
||
| resource "azurerm_resource_group" "test" { | ||
| name = "acctestRG-vhubroutetable-%d" |
There was a problem hiding this comment.
| name = "acctestRG-vhubroutetable-%d" | |
| name = "acctestRG-vhub-%d" |
| %s | ||
|
|
||
| resource "azurerm_virtual_hub_route_table" "test" { | ||
| name = "acctest-routetable-%d" |
There was a problem hiding this comment.
could we use some capitals here?
| name = "acctest-routetable-%d" | |
| name = "acctest-RouteTable-%d" |
| resource "azurerm_virtual_hub_route_table" "test" { | ||
| name = "acctest-routetable-%d" | ||
| virtual_hub_id = azurerm_virtual_hub.test.id | ||
| labels = ["label1"] |
There was a problem hiding this comment.
and here
| labels = ["label1"] | |
| labels = ["Label1"] |
| resource "azurerm_virtual_hub_route_table" "test" { | ||
| name = "acctest-routetable-%d" | ||
| virtual_hub_id = azurerm_virtual_hub.test.id | ||
| labels = ["label1"] |
There was a problem hiding this comment.
could we have more then one lable and check casing
| labels = ["label1"] | |
| labels = ["labeL1", "AnotherLabel"] |
| } | ||
|
|
||
| resource "azurerm_virtual_network" "test" { | ||
| name = "acctest-vnet-%d" |
There was a problem hiding this comment.
For all resources that support it can we use capitals for their names please?
|
|
||
| * `destinations_type` - (Required) The type of destinations. Possible values are `CIDR`, `ResourceId` and `Service`. | ||
|
|
||
| * `next_hop` - (Required) The next hop resource ID. |
There was a problem hiding this comment.
grammer
| * `next_hop` - (Required) The next hop resource ID. | |
| * `next_hop` - (Required) The next hop's resource ID. |
|
@katbyte , thanks for your comments. I've updated code. Please have a look. Thanks. |
katbyte
changed the title
|
This has been released in version 2.35.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 2.35.0"
}
# ... other configuration ... |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
ghost
locked as resolved and limited conversation to collaborators
API spec: https://docs.microsoft.com/en-us/rest/api/virtualwan/hubroutetables/createorupdate