Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_local_network_gateway: support for gateway_fqdn #8998

Merged
merged 5 commits into from
Oct 28, 2020

Conversation

magodo
Copy link
Collaborator

@magodo magodo commented Oct 23, 2020

Test Result

💤 make testacc TEST=./azurerm/internal/services/network/tests TESTARGS='-run TestAccAzureRMLocalNetworkGateway_fqdn'    
==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
==> Checking that acceptance test packages are used...
TF_ACC=1 go test ./azurerm/internal/services/network/tests -v -run TestAccAzureRMLocalNetworkGateway_fqdn -timeout 180m -ldflags="-X=github.com/terraform-providers/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccAzureRMLocalNetworkGateway_fqdn
=== PAUSE TestAccAzureRMLocalNetworkGateway_fqdn
=== CONT  TestAccAzureRMLocalNetworkGateway_fqdn
--- PASS: TestAccAzureRMLocalNetworkGateway_fqdn (127.35s)
PASS
ok      github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/network/tests       127.406s

@magodo
Copy link
Collaborator Author

magodo commented Oct 23, 2020

Note that the CI error seems unrelated to this PR.

Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if we can add an update test this otherwise LGTM 👍

@magodo
Copy link
Collaborator Author

magodo commented Oct 28, 2020

@tombuildsstuff Thank you for the feedback! I have updated the test per comment.

💤 make testacc TEST=./azurerm/internal/services/network/tests TESTARGS='-run TestAccAzureRMLocalNetworkGateway_fqdn'
==> Checking that code complies with gofmt requirements...  
==> Checking that Custom Timeouts are used...                                                                                                
==> Checking that acceptance test packages are used...                                                                                       
TF_ACC=1 go test ./azurerm/internal/services/network/tests -v -run TestAccAzureRMLocalNetworkGateway_fqdn -timeout 180m -ldflags="-X=github.com/terraform-providers/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccAzureRMLocalNetworkGateway_fqdn                 
=== PAUSE TestAccAzureRMLocalNetworkGateway_fqdn
=== CONT  TestAccAzureRMLocalNetworkGateway_fqdn                                                                                             
--- PASS: TestAccAzureRMLocalNetworkGateway_fqdn (197.12s)
PASS
ok      github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/network/tests       197.151s

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @magodo - aside from a couple minor comments this LGTM 👍

@katbyte katbyte merged commit 06a524d into hashicorp:master Oct 28, 2020
katbyte added a commit that referenced this pull request Oct 28, 2020
@ghost
Copy link

ghost commented Oct 29, 2020

This has been released in version 2.34.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.34.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Nov 28, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Nov 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants