add fields to loganalytics workspaces #9033
Conversation
There was a problem hiding this comment.
hi @dw511214992
Thanks for this PR.
I've taken a look through and left some comments inline - but if we can fix up the comments (and potentially update the field names to clarify what these actually do) then we should be able to take another look.
Thanks!
azurerm/internal/services/loganalytics/log_analytics_workspace_resource.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/loganalytics/log_analytics_workspace_resource.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/loganalytics/log_analytics_workspace_resource.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/loganalytics/log_analytics_workspace_resource.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/loganalytics/log_analytics_workspace_resource.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/loganalytics/log_analytics_workspace_resource.go
Outdated
Show resolved
Hide resolved
|
Hi @tombuildsstuff thanks for your review. I have updated the pr accroding to your comments. Also, I reply your comments, and please check it. |
|
Hi @tombuildsstuff The |
|
thanks @katbyte I have updated the pr based on your comments. |
|
@dw511214992 - could you fix up the merge conflicts? once those are fixed this will be good to merge |
# Conflicts: # azurerm/internal/services/loganalytics/log_analytics_workspace_resource.go # azurerm/internal/services/loganalytics/tests/log_analytics_workspace_resource_test.go
|
Hi @katbyte The conflicts has been resolved. Please help merge this pr as I have no permission to merge it. thanks |
|
This has been released in version 2.36.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 2.36.0"
}
# ... other configuration ... |
|
Hi @dw511214992 is there a reason why private_link_scoped_resource has been removed in one of your commit? Looks like there is no more opened issues to track that feature @arnaudlh |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
ghost
locked as resolved and limited conversation to collaborators
No description provided.