azurerm_log_analytics_saved_search - support for tags
#9034
Conversation
There was a problem hiding this comment.
hi @dw511214992
Thanks for this PR.
Taking a look through here it appears that we could use a regular Tags Schema here instead of this custom object?
Thanks!
azurerm/internal/services/loganalytics/log_analytics_saved_search_resource.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/loganalytics/tests/log_analytics_saved_search_resource_test.go
Outdated
Show resolved
Hide resolved
|
Thanks @tombuildsstuff I have updated the pr. please help re-review it. |
There was a problem hiding this comment.
Thanks @dw511214992 - i've given this a review and left some comments inline which i will address now. LGTM 👍
azurerm/internal/services/loganalytics/tests/log_analytics_saved_search_resource_test.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/loganalytics/tests/log_analytics_saved_search_resource_test.go
Show resolved
Hide resolved
…ed_search_resource_test.go
…ed_search_resource_test.go
katbyte
changed the title
tags
|
This has been released in version 2.34.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 2.34.0"
}
# ... other configuration ... |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
ghost
locked as resolved and limited conversation to collaborators
No description provided.