-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"azurerm_spring_cloud_service" - exporting outbound_public_ip_addresses
#9261
"azurerm_spring_cloud_service" - exporting outbound_public_ip_addresses
#9261
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hi @njuCZ
Thanks for this PR - I've taken a look through and left some comments inline but if we can clear those up then we should be good to go 👍
Thanks!
azurerm/internal/services/appplatform/spring_cloud_service_resource.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/appplatform/spring_cloud_service_resource.go
Outdated
Show resolved
Hide resolved
@tombuildsstuff I have moved the field to a top level field. Could you have a look again and check which way is better to solve the diff issue ? |
@katbyte Thanks for your suggestions. I have updated this PR and all acctest could pass. Please have a look again when free. |
f657fec
to
09334c6
Compare
@njuCZ hope you don't mind but I've pushed a commit to rebase this and move this field to the top level as discussed above |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @njuCZ & @tombuildsstuff - This LGTM now 👍
dismissing since changes have been pushed
43de5a6
to
b0eaa8e
Compare
b0eaa8e
to
d9377b3
Compare
Acceptance Tests look good 👍 |
outbound_public_ip_addresses
This has been released in version 2.38.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 2.38.0"
}
# ... other configuration ... |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
this PR serves two purpose:
the reason of issue 9346:
"outbound_ip" is a new field, and there is always a value for this field no matter spring cloud instance is in a virtual network.
so we could make "network" block computed to solve this issue.