added validation for eventgrid resources #9281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tombuildsstuff
approved these changes
Nov 12, 2020
tombuildsstuff
added a commit
that referenced
this pull request
Nov 12, 2020
|
This has been released in version 2.36.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 2.36.0"
}
# ... other configuration ... |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
riteshmodi@MININT-57VL578 terraform-provider-azurerm % make acctests SERVICE=eventgrid TESTARGS='-run=TestAccAzureRMEventGridTopic' TESTTIMEOUT='120m'
==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
==> Checking that acceptance test packages are used...
TF_ACC=1 go test -v ./azurerm/internal/services/eventgrid/tests/ -run=TestAccAzureRMEventGridTopic -timeout 120m -ldflags="-X=github.com/terraform-providers/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN TestAccAzureRMEventGridTopic_basic
=== PAUSE TestAccAzureRMEventGridTopic_basic
=== RUN TestAccAzureRMEventGridTopic_requiresImport
=== PAUSE TestAccAzureRMEventGridTopic_requiresImport
=== RUN TestAccAzureRMEventGridTopic_mapping
=== PAUSE TestAccAzureRMEventGridTopic_mapping
=== RUN TestAccAzureRMEventGridTopic_basicWithTags
=== PAUSE TestAccAzureRMEventGridTopic_basicWithTags
=== CONT TestAccAzureRMEventGridTopic_basic
=== CONT TestAccAzureRMEventGridTopic_basicWithTags
=== CONT TestAccAzureRMEventGridTopic_mapping
=== CONT TestAccAzureRMEventGridTopic_requiresImport
--- PASS: TestAccAzureRMEventGridTopic_mapping (115.51s)
--- PASS: TestAccAzureRMEventGridTopic_basicWithTags (129.53s)
--- PASS: TestAccAzureRMEventGridTopic_basic (161.45s)
--- PASS: TestAccAzureRMEventGridTopic_requiresImport (166.01s)
PASS
ok github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/eventgrid/tests (cached)
riteshmodi@MININT-57VL578 terraform-provider-azurerm % make acctests SERVICE=eventgrid TESTARGS='-run=TestAccAzureRMEventGridEventSubscription' TESTTIMEOUT='120m'
==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
==> Checking that acceptance test packages are used...
TF_ACC=1 go test -v ./azurerm/internal/services/eventgrid/tests/ -run=TestAccAzureRMEventGridEventSubscription -timeout 120m -ldflags="-X=github.com/terraform-providers/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN TestAccAzureRMEventGridEventSubscription_basic
=== PAUSE TestAccAzureRMEventGridEventSubscription_basic
=== RUN TestAccAzureRMEventGridEventSubscription_requiresImport
=== PAUSE TestAccAzureRMEventGridEventSubscription_requiresImport
=== RUN TestAccAzureRMEventGridEventSubscription_eventHubID
=== PAUSE TestAccAzureRMEventGridEventSubscription_eventHubID
=== RUN TestAccAzureRMEventGridEventSubscription_serviceBusQueueID
=== PAUSE TestAccAzureRMEventGridEventSubscription_serviceBusQueueID
=== RUN TestAccAzureRMEventGridEventSubscription_serviceBusTopicID
=== PAUSE TestAccAzureRMEventGridEventSubscription_serviceBusTopicID
=== RUN TestAccAzureRMEventGridEventSubscription_update
=== PAUSE TestAccAzureRMEventGridEventSubscription_update
=== RUN TestAccAzureRMEventGridEventSubscription_filter
=== PAUSE TestAccAzureRMEventGridEventSubscription_filter
=== RUN TestAccAzureRMEventGridEventSubscription_advancedFilter
=== PAUSE TestAccAzureRMEventGridEventSubscription_advancedFilter
=== CONT TestAccAzureRMEventGridEventSubscription_basic
=== CONT TestAccAzureRMEventGridEventSubscription_update
=== CONT TestAccAzureRMEventGridEventSubscription_serviceBusQueueID
=== CONT TestAccAzureRMEventGridEventSubscription_eventHubID
=== CONT TestAccAzureRMEventGridEventSubscription_serviceBusTopicID
=== CONT TestAccAzureRMEventGridEventSubscription_requiresImport
=== CONT TestAccAzureRMEventGridEventSubscription_advancedFilter
=== CONT TestAccAzureRMEventGridEventSubscription_filter
--- PASS: TestAccAzureRMEventGridEventSubscription_advancedFilter (159.32s)
--- PASS: TestAccAzureRMEventGridEventSubscription_filter (160.66s)
--- PASS: TestAccAzureRMEventGridEventSubscription_basic (221.81s)
--- PASS: TestAccAzureRMEventGridEventSubscription_requiresImport (234.13s)
--- PASS: TestAccAzureRMEventGridEventSubscription_serviceBusQueueID (284.66s)
--- PASS: TestAccAzureRMEventGridEventSubscription_serviceBusTopicID (317.90s)
--- PASS: TestAccAzureRMEventGridEventSubscription_update (343.11s)
--- PASS: TestAccAzureRMEventGridEventSubscription_eventHubID (371.25s)
PASS
ok github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/eventgrid/tests 371.310s
riteshmodi@MININT-57VL578 terraform-provider-azurerm % make acctests SERVICE=eventgrid TESTARGS='-run=TestAccAzureRMEventGridTopic' TESTTIMEOUT='120m'
==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
==> Checking that acceptance test packages are used...
TF_ACC=1 go test -v ./azurerm/internal/services/eventgrid/tests/ -run=TestAccAzureRMEventGridTopic -timeout 120m -ldflags="-X=github.com/terraform-providers/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN TestAccAzureRMEventGridTopic_basic
=== PAUSE TestAccAzureRMEventGridTopic_basic
=== RUN TestAccAzureRMEventGridTopic_requiresImport
=== PAUSE TestAccAzureRMEventGridTopic_requiresImport
=== RUN TestAccAzureRMEventGridTopic_mapping
=== PAUSE TestAccAzureRMEventGridTopic_mapping
=== RUN TestAccAzureRMEventGridTopic_basicWithTags
=== PAUSE TestAccAzureRMEventGridTopic_basicWithTags
=== CONT TestAccAzureRMEventGridTopic_basic
=== CONT TestAccAzureRMEventGridTopic_basicWithTags
=== CONT TestAccAzureRMEventGridTopic_mapping
=== CONT TestAccAzureRMEventGridTopic_requiresImport
--- PASS: TestAccAzureRMEventGridTopic_mapping (115.51s)
--- PASS: TestAccAzureRMEventGridTopic_basicWithTags (129.53s)
--- PASS: TestAccAzureRMEventGridTopic_basic (161.45s)
--- PASS: TestAccAzureRMEventGridTopic_requiresImport (166.01s)
PASS
ok github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/eventgrid/tests (cached)
riteshmodi@MININT-57VL578 terraform-provider-azurerm % make acctests SERVICE=eventgrid TESTARGS='-run=TestAccAzureRMEventGridDomain' TESTTIMEOUT='120m'
==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
==> Checking that acceptance test packages are used...
TF_ACC=1 go test -v ./azurerm/internal/services/eventgrid/tests/ -run=TestAccAzureRMEventGridDomain -timeout 120m -ldflags="-X=github.com/terraform-providers/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN TestAccAzureRMEventGridDomain_basic
=== PAUSE TestAccAzureRMEventGridDomain_basic
=== RUN TestAccAzureRMEventGridDomain_requiresImport
=== PAUSE TestAccAzureRMEventGridDomain_requiresImport
=== RUN TestAccAzureRMEventGridDomain_mapping
=== PAUSE TestAccAzureRMEventGridDomain_mapping
=== RUN TestAccAzureRMEventGridDomain_basicWithTags
=== PAUSE TestAccAzureRMEventGridDomain_basicWithTags
=== RUN TestAccAzureRMEventGridDomainTopic_basic
=== PAUSE TestAccAzureRMEventGridDomainTopic_basic
=== RUN TestAccAzureRMEventGridDomainTopic_requiresImport
=== PAUSE TestAccAzureRMEventGridDomainTopic_requiresImport
=== CONT TestAccAzureRMEventGridDomain_basic
=== CONT TestAccAzureRMEventGridDomainTopic_basic
=== CONT TestAccAzureRMEventGridDomain_requiresImport
=== CONT TestAccAzureRMEventGridDomain_mapping
=== CONT TestAccAzureRMEventGridDomain_basicWithTags
=== CONT TestAccAzureRMEventGridDomainTopic_requiresImport
--- PASS: TestAccAzureRMEventGridDomain_basicWithTags (109.87s)
--- PASS: TestAccAzureRMEventGridDomain_basic (109.87s)
--- PASS: TestAccAzureRMEventGridDomain_mapping (109.88s)
--- PASS: TestAccAzureRMEventGridDomain_requiresImport (116.55s)
--- PASS: TestAccAzureRMEventGridDomainTopic_basic (198.40s)
--- PASS: TestAccAzureRMEventGridDomainTopic_requiresImport (205.41s)
PASS
ok github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/eventgrid/tests 205.467s
riteshmodi@MININT-57VL578 terraform-provider-azurerm % make acctests SERVICE=eventgrid TESTARGS='-run=TestAccAzureRMEventGridDomainTopic' TESTTIMEOUT='120m'
==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
==> Checking that acceptance test packages are used...
TF_ACC=1 go test -v ./azurerm/internal/services/eventgrid/tests/ -run=TestAccAzureRMEventGridDomainTopic -timeout 120m -ldflags="-X=github.com/terraform-providers/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN TestAccAzureRMEventGridDomainTopic_basic
=== PAUSE TestAccAzureRMEventGridDomainTopic_basic
=== RUN TestAccAzureRMEventGridDomainTopic_requiresImport
=== PAUSE TestAccAzureRMEventGridDomainTopic_requiresImport
=== CONT TestAccAzureRMEventGridDomainTopic_basic
=== CONT TestAccAzureRMEventGridDomainTopic_requiresImport
--- PASS: TestAccAzureRMEventGridDomainTopic_basic (139.16s)
--- PASS: TestAccAzureRMEventGridDomainTopic_requiresImport (150.37s)
PASS
ok github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/eventgrid/tests 150.415s
riteshmodi@MININT-57VL578 terraform-provider-azurerm % make acctests SERVICE=eventgrid TESTARGS='-run=TestAccAzureRMEventGridSystemTopic' TESTTIMEOUT='120m'
==> Checking that code complies with gofmt requirements...
==> Checking that Custom Timeouts are used...
==> Checking that acceptance test packages are used...
TF_ACC=1 go test -v ./azurerm/internal/services/eventgrid/tests/ -run=TestAccAzureRMEventGridSystemTopic -timeout 120m -ldflags="-X=github.com/terraform-providers/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN TestAccAzureRMEventGridSystemTopic_basic
=== PAUSE TestAccAzureRMEventGridSystemTopic_basic
=== RUN TestAccAzureRMEventGridSystemTopic_requiresImport
=== PAUSE TestAccAzureRMEventGridSystemTopic_requiresImport
=== RUN TestAccAzureRMEventGridSystemTopic_complete
=== PAUSE TestAccAzureRMEventGridSystemTopic_complete
=== CONT TestAccAzureRMEventGridSystemTopic_basic
=== CONT TestAccAzureRMEventGridSystemTopic_complete
=== CONT TestAccAzureRMEventGridSystemTopic_requiresImport
--- PASS: TestAccAzureRMEventGridSystemTopic_complete (158.83s)
--- PASS: TestAccAzureRMEventGridSystemTopic_requiresImport (163.93s)
--- PASS: TestAccAzureRMEventGridSystemTopic_basic (164.37s)
PASS
ok github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/eventgrid/tests 164.423s
riteshmodi@MININT-57VL578 terraform-provider-azurerm %