azurerm_dns_zone & azurerm_private_dns_zone - support for the soa_record block

[neil-yechenwei]

API doc for DNS SOA Record: https://docs.microsoft.com/en-us/rest/api/dns/recordsets/createorupdate#soarecord
API doc for Private DNS SOA Record: https://docs.microsoft.com/en-us/rest/api/dns/privatedns/recordsets/createorupdate#soarecord

DNS SOA Record and Private DNS SOA Record cannot be made as separate resource because they aren't allowed to be created and deleted by API. So they have to be embedded into dns zone resource and private dns zone resource.
See more details from below links:

1. https://docs.microsoft.com/en-us/rest/api/dns/privatedns/recordsets/delete#recordtype
2. https://docs.microsoft.com/en-us/rest/api/dns/privatedns/recordsets/createorupdate#recordtype
3. https://docs.microsoft.com/en-us/rest/api/dns/recordsets/createorupdate#recordtype
4. https://docs.microsoft.com/en-us/rest/api/dns/recordsets/delete#recordtype

[katbyte]

Thanks @neil-yechenwei - given that you cannot update or delete SOA records can we mark it and its properties as force new?

[neil-yechenwei]

@katbyte , thanks for your comments. I've updated code. Please have a look. Thanks.

[katbyte]

Thanks @neil-yechenwei - left a couple more comments inline

[neil-yechenwei]

@katbyte , thanks for your comments. I've updated code. Please have a look. Thanks.

[katbyte]

Thanks @neil-yechenwei - this LGTM now 👍

[ghost]

This has been released in version 2.37.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.37.0"
}
# ... other configuration ...

[delampri]

I see no documentation for this feature on provider 2.37 https://registry.terraform.io/providers/hashicorp/azurerm/latest/docs

[tombuildsstuff]

@neil-yechenwei can you send a PR to add this?

[neil-yechenwei]

@tombuildsstuff, seems I‘ve documented soa_record in azurerm_private_dns_zone and azurerm_dns_zone, right? If it's not expected, please correct me. Thanks.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!