Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Resource: azurerm_media_asset #9387

Merged
merged 21 commits into from
Dec 7, 2020
Merged

New Resource: azurerm_media_asset #9387

merged 21 commits into from
Dec 7, 2020

Conversation

jcanizalez
Copy link
Contributor

@jcanizalez jcanizalez commented Nov 19, 2020

Including the support for the creation and manipulation of Assets in Azure Media Services Account. This PR resolves #9323

Checked:

  • Include support for Assets in Azure Media Services Account.
  • Add Documentation
  • Include Examples
  • Add unit test and Acceptance Test and verified that the tests pass successfully
  • Linting is OK

@jcanizalez
Copy link
Contributor Author

The PR is ready for review now, all checks have passed

@jcanizalez jcanizalez changed the title Support for New Resource in Media Services "azurerm_media_asset" New Resource: azurerm_media_asset Nov 26, 2020
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jcanizalez - i've given this a review and overall it looks great, if you could address the comment i've left inline this should be good to merge 🙂

azurerm/internal/services/media/media_asset_resource.go Outdated Show resolved Hide resolved
website/docs/r/media_asset.html.markdown Outdated Show resolved Hide resolved
website/docs/r/media_asset.html.markdown Outdated Show resolved Hide resolved
@jcanizalez
Copy link
Contributor Author

Thanks @katbyte I already pushed some changes that resolves your comments. So you can continue checking

@jcanizalez jcanizalez requested a review from katbyte December 1, 2020 17:32
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jcanizalez - aside from a view minor comments this LGTM 👍

@katbyte katbyte added this to the v2.40.0 milestone Dec 7, 2020
@katbyte katbyte merged commit 41474ad into hashicorp:master Dec 7, 2020
katbyte added a commit that referenced this pull request Dec 7, 2020
@ghost
Copy link

ghost commented Dec 10, 2020

This has been released in version 2.40.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.40.0"
}
# ... other configuration ...

@jcanizalez jcanizalez deleted the master branch December 14, 2020 16:14
@ghost
Copy link

ghost commented Jan 7, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Jan 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for Assets in Azure Media Services Account
3 participants