-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Resource: azurerm_media_asset #9387
Conversation
The PR is ready for review now, all checks have passed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jcanizalez - i've given this a review and overall it looks great, if you could address the comment i've left inline this should be good to merge 🙂
azurerm/internal/services/media/tests/media_asset_resource_test.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/media/tests/media_asset_resource_test.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/media/tests/media_asset_resource_test.go
Outdated
Show resolved
Hide resolved
Co-authored-by: kt <kt@katbyte.me>
Thanks @katbyte I already pushed some changes that resolves your comments. So you can continue checking |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jcanizalez - aside from a view minor comments this LGTM 👍
azurerm/internal/services/media/tests/media_asset_resource_test.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/media/tests/media_asset_resource_test.go
Outdated
Show resolved
Hide resolved
azurerm/internal/services/media/tests/media_asset_resource_test.go
Outdated
Show resolved
Hide resolved
This has been released in version 2.40.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 2.40.0"
}
# ... other configuration ... |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
Including the support for the creation and manipulation of Assets in Azure Media Services Account. This PR resolves #9323
Checked: