New Resource: azurerm_app_service_certificate_binding

[AdamCoulterOz]

This fixes #8069.

This is a separation of the certificate binding from the existing azurerm_app_service_custom_hostname_binding. This new resource azurerm_app_service_certificate_binding breaks the circular dependency with the azurerm_app_service_managed_certificate needing to be created after the azurerm_app_service_custom_hostname_binding resource, but before the certificate association part of it.

This still needs tests and documentation, will add in the next few days.

@phekmat / @imod - does this help address both of your contexts within #8069 ?

[imod]

I think it does 👍

[imod]

thinking about it again... sorry i was a bit confused: the original issue was to introduce the ability to create 'managed certificates' (#4824). So this is "only" the prerequisite.
The reason why I referenced https://github.com/pulumi/pulumi-azure-nextgen/issues/129 was the fact that pulumi suffers the same problem - with the new implementation (azure-nextgen) which does not use the azure terraform provider anymore.

[AdamCoulterOz]

@imod yeah I've been chipping away at @4824... we have a few PRs open right now which will complete it once finished... #9378 #9415 #9409... I've got a branch with them all merged if you want to build you own for now...

https://github.com/AdamCoulterOz/terraform-provider-azurerm/tree/app_service_and_custom_domain

[AdamCoulterOz]

@jackofallops we need this included in the next azurerm release... what can I do to help get it there?

[jackofallops]

@jackofallops we need this included in the next azurerm release... what can I do to help get it there?

Hi @AdamCoulterOz - I have this covered in the PR 9631 mentioned above, hopefully get it into today's release.

[jackofallops]

Tests passing locally:

=== RUN   TestAccAzureRMAppServiceCertificateBinding_basic
=== PAUSE TestAccAzureRMAppServiceCertificateBinding_basic
=== CONT  TestAccAzureRMAppServiceCertificateBinding_basic
--- PASS: TestAccAzureRMAppServiceCertificateBinding_basic (247.86s)
=== RUN   TestAccAzureRMAppServiceCertificateBinding_requiresImport
=== PAUSE TestAccAzureRMAppServiceCertificateBinding_requiresImport
=== CONT  TestAccAzureRMAppServiceCertificateBinding_requiresImport
--- PASS: TestAccAzureRMAppServiceCertificateBinding_requiresImport (269.07s)
PASS

[tombuildsstuff]

hey @AdamCoulterOz @jackofallops

Thanks for this PR.

I've taken a look through and left some comments inline but this otherwise LGTM 👍

Thanks!

[jackofallops]

Post review fix tests passing:

=== PAUSE TestAccAzureRMAppServiceCertificateBinding_basic
=== CONT  TestAccAzureRMAppServiceCertificateBinding_basic
--- PASS: TestAccAzureRMAppServiceCertificateBinding_basic (352.98s)
=== RUN   TestAccAzureRMAppServiceCertificateBinding_basicSniEnabled
=== PAUSE TestAccAzureRMAppServiceCertificateBinding_basicSniEnabled
=== CONT  TestAccAzureRMAppServiceCertificateBinding_basicSniEnabled
--- PASS: TestAccAzureRMAppServiceCertificateBinding_basicSniEnabled (308.68s)
=== RUN   TestAccAzureRMAppServiceCertificateBinding_requiresImport
=== PAUSE TestAccAzureRMAppServiceCertificateBinding_requiresImport
=== CONT  TestAccAzureRMAppServiceCertificateBinding_requiresImport
--- PASS: TestAccAzureRMAppServiceCertificateBinding_requiresImport (371.84s)
PASS```

[ghost]

This has been released in version 2.40.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.40.0"
}
# ... other configuration ...

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!