azurerm_iothub_digital_twins -> azurerm_digital_twins_instance
#9430
Conversation
|
|
| ctx, cancel := timeouts.ForCreate(meta.(*clients.Client).StopContext, d) | ||
| defer cancel() | ||
|
|
||
| name := d.Get("name").(string) | ||
| resourceGroup := d.Get("resource_group_name").(string) | ||
|
|
||
| id := parse.NewDigitalTwinsInstanceID(subscriptionId, resourceGroup, name) |
There was a problem hiding this comment.
if we format this here:
| id := parse.NewDigitalTwinsInstanceID(subscriptionId, resourceGroup, name) | |
| id := parse.NewDigitalTwinsInstanceID(subscriptionId, resourceGroup, name).ID("") |
| } | ||
| } | ||
| if existing.ID != nil && *existing.ID != "" { | ||
| return tf.ImportAsExistsError("azurerm_iothub_digital_twins", *existing.ID) | ||
| return tf.ImportAsExistsError("azurerm_digital_twins_instance", *existing.ID) | ||
| } |
There was a problem hiding this comment.
we can then use that here:
| } | |
| if !utils.ResponseWasNotFound(existing.Response) { | |
| return tf.ImportAsExistsError("azurerm_digital_twins_instance", id) | |
| } |
| id, err := parse.DigitalTwinsID(*resp.ID) | ||
| if err != nil { | ||
| return err | ||
| } | ||
| d.SetId(id.ID(subscriptionId)) |
There was a problem hiding this comment.
we'll be removing this subscriptionId field - so whilst this isn't technically an issue - we may as well switch this out for an empty string early since we're making another change here (it's provided on the constructor above now)
| d.SetId(id.ID(subscriptionId)) | |
| d.SetId(id.ID("")) |
|
This has been released in version 2.38.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example: provider "azurerm" {
version = "~> 2.38.0"
}
# ... other configuration ... |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
ghost
locked as resolved and limited conversation to collaborators
Fixing PR Comment left on #9212