Added new resource azurerm_scheduler_job_collection #963
Conversation
katbyte
force-pushed
the
f-scheduler_job_collection
branch
2 times, most recently
from
189fac6 to
134c351
Compare
katbyte
force-pushed
the
f-scheduler_job_collection
branch
from
134c351 to
76c27ee
Compare
| "state": { | ||
| Type: schema.TypeString, | ||
| Optional: true, | ||
| Default: "enabled", |
There was a problem hiding this comment.
can we make this ‘string(scheduler.Enabled)’
| Elem: &schema.Resource{ | ||
| Schema: map[string]*schema.Schema{ | ||
|
|
||
| //max_job_occurrence doesn't seem to do anything and always remains empty |
There was a problem hiding this comment.
Given that I guess this field is deprecated (or the API’s broken) - so we can ignore it for now 👍
| }, | ||
|
|
||
| //should this be max_retry_interval ? given that is what the documentation implies | ||
| "max_recurrence_interval": { |
There was a problem hiding this comment.
Yep, that makes sense to rename this to be clearer
| string(scheduler.Enabled), | ||
| string(scheduler.Suspended), | ||
| string(scheduler.Disabled), | ||
| string(scheduler.Deleted), |
There was a problem hiding this comment.
Is it possible to set Deleted?
There was a problem hiding this comment.
Surprisingly, yes! But it probably does make sense to prevent it.
| recurrence.Interval = utils.Int32(int32(v)) | ||
| } | ||
|
|
||
| properties.Quota = "a |
There was a problem hiding this comment.
minor can we pull this out into an “expandSchedulerJobCollectionQuota” function
| quotaBlock["max_recurrence_frequency"] = string(recurrence.Frequency) | ||
| } | ||
|
|
||
| d.Set("quota", []interface{}{quotaBlock}) |
There was a problem hiding this comment.
Can we pull this out into a “flattenSchedulerJobCollectionQuota” function and check for errors when assigning it?
| return resourceArmSchedulerJobCollectionPopulate(d, resourceGroup, &collection) | ||
| } | ||
|
|
||
| func resourceArmSchedulerJobCollectionPopulate(d *schema.ResourceData, resourceGroup string, collection *scheduler.JobCollectionDefinition) error { |
There was a problem hiding this comment.
We should be able to move this into the Read method?
There was a problem hiding this comment.
I separated it out like this so there wouldn't be two read requests after a create/update.
| name := rs.Primary.Attributes["name"] | ||
| resourceGroup := rs.Primary.Attributes["resource_group_name"] | ||
|
|
||
| client := testAccProvider.Meta().(*ArmClient).applicationSecurityGroupsClient |
There was a problem hiding this comment.
Can we use the right client here? :)
|
|
||
| func testAccAzureRMSchedulerJobCollection_complete(rInt int, location string) string { | ||
| return testAccAzureRMSchedulerJobCollection_basic(rInt, location, ` | ||
| state = "disabled" |
There was a problem hiding this comment.
can we combine this into one function?
|
|
||
| ## Import | ||
|
|
||
| Application Security Groups can be imported using the `resource id`, e.g. |
There was a problem hiding this comment.
Scheduler Job collections*
|
Thanks for the review! Pushed requested changes. |
| d.Set("state", string(properties.State)) | ||
|
|
||
| if err := d.Set("quota", flattenAzureArmSchedulerJobCollectionQuota(properties.Quota)); err != nil { | ||
| return fmt.Errorf("Error flattening quoto for Job Collection %q (Resource Group %q): %+v", collection.Name, resourceGroup, err) |
There was a problem hiding this comment.
minor quoto -> quota
| max_recurrence_frequency = "hour" | ||
| max_retry_interval = 10 | ||
| max_job_count = 10 | ||
| } |
There was a problem hiding this comment.
can we separate this out into a separate configuration called testAccAzureRMSchedulerJobCollection_complete to match the other tests?
katbyte
force-pushed
the
f-scheduler_job_collection
branch
4 times, most recently
from
12cb989 to
790b30c
Compare
katbyte
force-pushed
the
f-scheduler_job_collection
branch
from
790b30c to
c4f7781
Compare
|
Tests pass: |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
ghost
locked and limited conversation to collaborators
No description provided.