-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New resource azurerm_digital_twins_endpoint_eventhub
#9673
New resource azurerm_digital_twins_endpoint_eventhub
#9673
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yupwei68 Thanks you for submitting this PR, it's looking really good so far and is almost there. I left a couple of comments if you don't mind making those changes I think this would be good to go! 🚀
azurerm/internal/services/digitaltwins/digital_twins_endpoint_eventhub_resource.go
Show resolved
Hide resolved
azurerm/internal/services/digitaltwins/digital_twins_endpoint_eventhub_resource.go
Show resolved
Hide resolved
azurerm/internal/services/digitaltwins/digital_twins_endpoint_eventhub_resource.go
Show resolved
Hide resolved
azurerm/internal/services/digitaltwins/digital_twins_endpoint_eventhub_resource.go
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yupwei68, this looks good however I missed something on my first review, can we get the test names updated? I think once that is done we are good to go. 🚀
azurerm/internal/services/digitaltwins/digital_twins_endpoint_eventhub_resource_test.go
Outdated
Show resolved
Hide resolved
@WodansSon Thanks Jeffrey for latest information. Changes have been pushed. Please continue reviewing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yupwei68, thanks for pushing the changes! This LGTM now! 🚀
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
Partial fix: #9211
=== RUN TestAccAzureRMDigitalTwinsEndpointEventHub_basic
=== PAUSE TestAccAzureRMDigitalTwinsEndpointEventHub_basic
=== CONT TestAccAzureRMDigitalTwinsEndpointEventHub_basic
--- PASS: TestAccAzureRMDigitalTwinsEndpointEventHub_basic (348.23s)
=== RUN TestAccAzureRMDigitalTwinsEndpointEventHub_requiresImport
=== PAUSE TestAccAzureRMDigitalTwinsEndpointEventHub_requiresImport
=== CONT TestAccAzureRMDigitalTwinsEndpointEventHub_requiresImport
--- PASS: TestAccAzureRMDigitalTwinsEndpointEventHub_requiresImport (363.34s)
=== RUN TestAccAzureRMDigitalTwinsEndpointEventHub_updateEventHub
=== PAUSE TestAccAzureRMDigitalTwinsEndpointEventHub_updateEventHub
=== CONT TestAccAzureRMDigitalTwinsEndpointEventHub_updateEventHub
--- PASS: TestAccAzureRMDigitalTwinsEndpointEventHub_updateEventHub (471.41s)
=== RUN TestAccAzureRMDigitalTwinsEndpointEventHub_updateDeadLetter
=== PAUSE TestAccAzureRMDigitalTwinsEndpointEventHub_updateDeadLetter
=== CONT TestAccAzureRMDigitalTwinsEndpointEventHub_updateDeadLetter
--- PASS: TestAccAzureRMDigitalTwinsEndpointEventHub_updateDeadLetter (479.86s)