Switch loganalytics to generated resourceids #9764

favoretti · 2020-12-08T22:19:07Z

Switch loganalytics to generated resource IDs, upgrade to 2020-08-01

favoretti · 2020-12-09T14:53:43Z

Ok, only freeTier acceptance test fails now, I'll pretend it doesn't exist for now 🙈

$ TF_ACC=1 go test -v ./azurerm/internal/services/loganalytics -timeout=1000m
=== RUN   TestAccAzureRMLogAnalyticsDataExportRule_basic
=== PAUSE TestAccAzureRMLogAnalyticsDataExportRule_basic
=== RUN   TestAccAzureRMLogAnalyticsDataExportRule_requiresImport
=== PAUSE TestAccAzureRMLogAnalyticsDataExportRule_requiresImport
=== RUN   TestAccAzureRMLogAnalyticsDataExportRule_update
=== PAUSE TestAccAzureRMLogAnalyticsDataExportRule_update
=== RUN   TestAccAzureRMLogAnalyticsDataExportRule_complete
=== PAUSE TestAccAzureRMLogAnalyticsDataExportRule_complete
=== RUN   TestAccAzureRMLogAnalyticsDataSourceWindowsEvent_basic
=== PAUSE TestAccAzureRMLogAnalyticsDataSourceWindowsEvent_basic
=== RUN   TestAccAzureRMLogAnalyticsDataSourceWindowsEvent_complete
=== PAUSE TestAccAzureRMLogAnalyticsDataSourceWindowsEvent_complete
=== RUN   TestAccAzureRMLogAnalyticsDataSourceWindowsEvent_update
=== PAUSE TestAccAzureRMLogAnalyticsDataSourceWindowsEvent_update
=== RUN   TestAccAzureRMLogAnalyticsDataSourceWindowsEvent_requiresImport
=== PAUSE TestAccAzureRMLogAnalyticsDataSourceWindowsEvent_requiresImport
=== RUN   TestAccAzureRMLogAnalyticsDataSourceWindowsPerformanceCounter_basic
=== PAUSE TestAccAzureRMLogAnalyticsDataSourceWindowsPerformanceCounter_basic
=== RUN   TestAccAzureRMLogAnalyticsDataSourceWindowsPerformanceCounter_complete
=== PAUSE TestAccAzureRMLogAnalyticsDataSourceWindowsPerformanceCounter_complete
=== RUN   TestAccAzureRMLogAnalyticsDataSourceWindowsPerformanceCounter_update
=== PAUSE TestAccAzureRMLogAnalyticsDataSourceWindowsPerformanceCounter_update
=== RUN   TestAccAzureRMLogAnalyticsDataSourceWindowsPerformanceCounter_requiresImport
=== PAUSE TestAccAzureRMLogAnalyticsDataSourceWindowsPerformanceCounter_requiresImport
=== RUN   TestAccAzureRMLogAnalyticsLinkedService_basic
=== PAUSE TestAccAzureRMLogAnalyticsLinkedService_basic
=== RUN   TestAccAzureRMLogAnalyticsLinkedService_requiresImport
=== PAUSE TestAccAzureRMLogAnalyticsLinkedService_requiresImport
=== RUN   TestAccAzureRMLogAnalyticsLinkedService_complete
=== PAUSE TestAccAzureRMLogAnalyticsLinkedService_complete
=== RUN   TestAccAzureRMlogAnalyticsLinkedStorageAccount_basic
=== PAUSE TestAccAzureRMlogAnalyticsLinkedStorageAccount_basic
=== RUN   TestAccAzureRMlogAnalyticsLinkedStorageAccount_requiresImport
=== PAUSE TestAccAzureRMlogAnalyticsLinkedStorageAccount_requiresImport
=== RUN   TestAccAzureRMlogAnalyticsLinkedStorageAccount_complete
=== PAUSE TestAccAzureRMlogAnalyticsLinkedStorageAccount_complete
=== RUN   TestAccAzureRMlogAnalyticsLinkedStorageAccount_update
=== PAUSE TestAccAzureRMlogAnalyticsLinkedStorageAccount_update
=== RUN   TestAccAzureRMLogAnalyticsSavedSearch_basic
=== PAUSE TestAccAzureRMLogAnalyticsSavedSearch_basic
=== RUN   TestAccAzureRMLogAnalyticsSavedSearch_complete
=== PAUSE TestAccAzureRMLogAnalyticsSavedSearch_complete
=== RUN   TestAccAzureRMLogAnalyticsSavedSearch_withTag
=== PAUSE TestAccAzureRMLogAnalyticsSavedSearch_withTag
=== RUN   TestAccAzureRMLogAnalyticsSavedSearch_requiresImport
=== PAUSE TestAccAzureRMLogAnalyticsSavedSearch_requiresImport
=== RUN   TestAccAzureRMLogAnalyticsSolution_basicContainerMonitoring
=== PAUSE TestAccAzureRMLogAnalyticsSolution_basicContainerMonitoring
=== RUN   TestAccAzureRMLogAnalyticsSolution_requiresImport
=== PAUSE TestAccAzureRMLogAnalyticsSolution_requiresImport
=== RUN   TestAccAzureRMLogAnalyticsSolution_basicSecurity
=== PAUSE TestAccAzureRMLogAnalyticsSolution_basicSecurity
=== RUN   TestAccAzureRMLogAnalyticsStorageInsights_basic
=== PAUSE TestAccAzureRMLogAnalyticsStorageInsights_basic
=== RUN   TestAccAzureRMLogAnalyticsStorageInsights_requiresImport
=== PAUSE TestAccAzureRMLogAnalyticsStorageInsights_requiresImport
=== RUN   TestAccAzureRMLogAnalyticsStorageInsights_complete
=== PAUSE TestAccAzureRMLogAnalyticsStorageInsights_complete
=== RUN   TestAccAzureRMLogAnalyticsStorageInsights_update
=== PAUSE TestAccAzureRMLogAnalyticsStorageInsights_update
=== RUN   TestAccAzureRMLogAnalyticsStorageInsights_updateStorageAccount
=== PAUSE TestAccAzureRMLogAnalyticsStorageInsights_updateStorageAccount
=== RUN   TestAccDataSourceAzureRMLogAnalyticsWorkspace_basic
=== PAUSE TestAccDataSourceAzureRMLogAnalyticsWorkspace_basic
=== RUN   TestAccDataSourceAzureRMLogAnalyticsWorkspace_volumeCapWithDataSource
=== PAUSE TestAccDataSourceAzureRMLogAnalyticsWorkspace_volumeCapWithDataSource
=== RUN   TestAccAzureRMLogAnalyticsWorkspace_basic
=== PAUSE TestAccAzureRMLogAnalyticsWorkspace_basic
=== RUN   TestAccAzureRMLogAnalyticsWorkspace_requiresImport
=== PAUSE TestAccAzureRMLogAnalyticsWorkspace_requiresImport
=== RUN   TestAccAzureRMLogAnalyticsWorkspace_complete
=== PAUSE TestAccAzureRMLogAnalyticsWorkspace_complete
=== RUN   TestAccAzureRMLogAnalyticsWorkspace_freeTier
=== PAUSE TestAccAzureRMLogAnalyticsWorkspace_freeTier
=== RUN   TestAccAzureRMLogAnalyticsWorkspace_withDefaultSku
=== PAUSE TestAccAzureRMLogAnalyticsWorkspace_withDefaultSku
=== RUN   TestAccAzureRMLogAnalyticsWorkspace_withVolumeCap
=== PAUSE TestAccAzureRMLogAnalyticsWorkspace_withVolumeCap
=== RUN   TestAccAzureRMLogAnalyticsWorkspace_removeVolumeCap
=== PAUSE TestAccAzureRMLogAnalyticsWorkspace_removeVolumeCap
=== RUN   TestAccAzureRMLogAnalyticsWorkspace_withInternetIngestionEnabled
=== PAUSE TestAccAzureRMLogAnalyticsWorkspace_withInternetIngestionEnabled
=== RUN   TestAccAzureRMLogAnalyticsWorkspace_withInternetQueryEnabled
=== PAUSE TestAccAzureRMLogAnalyticsWorkspace_withInternetQueryEnabled
=== CONT  TestAccAzureRMLogAnalyticsDataExportRule_basic
=== CONT  TestAccAzureRMLogAnalyticsSavedSearch_requiresImport
=== CONT  TestAccAzureRMLogAnalyticsWorkspace_requiresImport
=== CONT  TestAccAzureRMLogAnalyticsStorageInsights_complete
=== CONT  TestAccAzureRMLogAnalyticsSolution_basicSecurity
=== CONT  TestAccAzureRMLogAnalyticsWorkspace_withInternetQueryEnabled
=== CONT  TestAccAzureRMLogAnalyticsWorkspace_withInternetIngestionEnabled
=== CONT  TestAccAzureRMLogAnalyticsWorkspace_removeVolumeCap
=== CONT  TestAccAzureRMLogAnalyticsWorkspace_withVolumeCap
=== CONT  TestAccAzureRMLogAnalyticsWorkspace_withDefaultSku
=== CONT  TestAccAzureRMLogAnalyticsWorkspace_freeTier
=== CONT  TestAccAzureRMLogAnalyticsWorkspace_complete
=== CONT  TestAccAzureRMLogAnalyticsStorageInsights_requiresImport
=== CONT  TestAccAzureRMLogAnalyticsStorageInsights_basic
=== CONT  TestAccAzureRMLogAnalyticsSolution_requiresImport
=== CONT  TestAccAzureRMLogAnalyticsWorkspace_basic
=== CONT  TestAccAzureRMLogAnalyticsWorkspace_freeTier
    testing.go:684: Step 0 error: errors during apply:

        Error: operationalinsights.WorkspacesClient#CreateOrUpdate: Invalid input: autorest/validation: validation failed: parameter=parameters.WorkspaceProperties.RetentionInDays constraint=InclusiveMinimum value=7 details: value must be greater than or equal to 30

          on /var/folders/_j/kwsxcxl974z5c6hz5lgldrkh0000gn/T/tf-test881710858/main.tf line 11:
          (source code not available)


--- FAIL: TestAccAzureRMLogAnalyticsWorkspace_freeTier (84.35s)
=== CONT  TestAccAzureRMLogAnalyticsDataSourceWindowsPerformanceCounter_requiresImport
--- PASS: TestAccAzureRMLogAnalyticsWorkspace_requiresImport (172.89s)
=== CONT  TestAccAzureRMLogAnalyticsSavedSearch_withTag
--- PASS: TestAccAzureRMLogAnalyticsWorkspace_withDefaultSku (173.21s)
=== CONT  TestAccAzureRMLogAnalyticsSavedSearch_complete
--- PASS: TestAccAzureRMLogAnalyticsWorkspace_basic (174.36s)
=== CONT  TestAccAzureRMLogAnalyticsSavedSearch_basic
--- PASS: TestAccAzureRMLogAnalyticsStorageInsights_basic (174.86s)
=== CONT  TestAccAzureRMlogAnalyticsLinkedStorageAccount_update
--- PASS: TestAccAzureRMLogAnalyticsStorageInsights_complete (175.67s)
=== CONT  TestAccAzureRMlogAnalyticsLinkedStorageAccount_complete
--- PASS: TestAccAzureRMLogAnalyticsDataExportRule_basic (176.51s)
=== CONT  TestAccAzureRMlogAnalyticsLinkedStorageAccount_requiresImport
--- PASS: TestAccAzureRMLogAnalyticsSolution_basicSecurity (180.71s)
=== CONT  TestAccAzureRMlogAnalyticsLinkedStorageAccount_basic
--- PASS: TestAccAzureRMLogAnalyticsSavedSearch_requiresImport (181.12s)
=== CONT  TestAccAzureRMLogAnalyticsLinkedService_complete
--- PASS: TestAccAzureRMLogAnalyticsWorkspace_withVolumeCap (183.33s)
=== CONT  TestAccAzureRMLogAnalyticsLinkedService_requiresImport
--- PASS: TestAccAzureRMLogAnalyticsSolution_requiresImport (183.68s)
=== CONT  TestAccAzureRMLogAnalyticsLinkedService_basic
--- PASS: TestAccAzureRMLogAnalyticsStorageInsights_requiresImport (186.42s)
=== CONT  TestAccDataSourceAzureRMLogAnalyticsWorkspace_basic
--- PASS: TestAccAzureRMLogAnalyticsWorkspace_complete (196.95s)
=== CONT  TestAccDataSourceAzureRMLogAnalyticsWorkspace_volumeCapWithDataSource
--- PASS: TestAccAzureRMLogAnalyticsWorkspace_withInternetQueryEnabled (200.92s)
=== CONT  TestAccAzureRMLogAnalyticsStorageInsights_update
--- PASS: TestAccAzureRMLogAnalyticsWorkspace_removeVolumeCap (201.19s)
=== CONT  TestAccAzureRMLogAnalyticsSolution_basicContainerMonitoring
--- PASS: TestAccAzureRMLogAnalyticsWorkspace_withInternetIngestionEnabled (201.46s)
=== CONT  TestAccAzureRMLogAnalyticsDataSourceWindowsEvent_update
--- PASS: TestAccAzureRMLogAnalyticsDataSourceWindowsPerformanceCounter_requiresImport (205.06s)
=== CONT  TestAccAzureRMLogAnalyticsDataSourceWindowsPerformanceCounter_update
--- PASS: TestAccAzureRMLogAnalyticsSavedSearch_complete (163.65s)
=== CONT  TestAccAzureRMLogAnalyticsDataSourceWindowsPerformanceCounter_complete
--- PASS: TestAccAzureRMLogAnalyticsSavedSearch_withTag (164.98s)
=== CONT  TestAccAzureRMLogAnalyticsDataSourceWindowsPerformanceCounter_basic
--- PASS: TestAccAzureRMLogAnalyticsSavedSearch_basic (180.95s)
=== CONT  TestAccAzureRMLogAnalyticsDataSourceWindowsEvent_requiresImport
--- PASS: TestAccDataSourceAzureRMLogAnalyticsWorkspace_basic (169.71s)
=== CONT  TestAccAzureRMLogAnalyticsDataExportRule_complete
--- PASS: TestAccAzureRMlogAnalyticsLinkedStorageAccount_requiresImport (196.52s)
=== CONT  TestAccAzureRMLogAnalyticsDataSourceWindowsEvent_basic
--- PASS: TestAccDataSourceAzureRMLogAnalyticsWorkspace_volumeCapWithDataSource (176.99s)
=== CONT  TestAccAzureRMLogAnalyticsDataExportRule_update
--- PASS: TestAccAzureRMlogAnalyticsLinkedStorageAccount_basic (195.09s)
=== CONT  TestAccAzureRMLogAnalyticsStorageInsights_updateStorageAccount
--- PASS: TestAccAzureRMLogAnalyticsLinkedService_requiresImport (194.13s)
=== CONT  TestAccAzureRMLogAnalyticsDataExportRule_requiresImport
--- PASS: TestAccAzureRMLogAnalyticsLinkedService_basic (198.12s)
=== CONT  TestAccAzureRMLogAnalyticsDataSourceWindowsEvent_complete
--- PASS: TestAccAzureRMlogAnalyticsLinkedStorageAccount_complete (209.31s)
--- PASS: TestAccAzureRMLogAnalyticsSolution_basicContainerMonitoring (183.82s)
--- PASS: TestAccAzureRMLogAnalyticsDataSourceWindowsPerformanceCounter_complete (103.21s)
--- PASS: TestAccAzureRMLogAnalyticsDataSourceWindowsPerformanceCounter_basic (102.38s)
--- PASS: TestAccAzureRMLogAnalyticsDataSourceWindowsPerformanceCounter_update (159.17s)
--- PASS: TestAccAzureRMLogAnalyticsDataSourceWindowsEvent_requiresImport (114.87s)
--- PASS: TestAccAzureRMlogAnalyticsLinkedStorageAccount_update (299.66s)
--- PASS: TestAccAzureRMLogAnalyticsStorageInsights_update (277.02s)
--- PASS: TestAccAzureRMLogAnalyticsDataExportRule_complete (129.60s)
--- PASS: TestAccAzureRMLogAnalyticsDataSourceWindowsEvent_update (292.44s)
--- PASS: TestAccAzureRMLogAnalyticsLinkedService_complete (317.32s)
--- PASS: TestAccAzureRMLogAnalyticsDataSourceWindowsEvent_complete (121.83s)
--- PASS: TestAccAzureRMLogAnalyticsDataSourceWindowsEvent_basic (133.54s)
--- PASS: TestAccAzureRMLogAnalyticsDataExportRule_requiresImport (155.48s)
--- PASS: TestAccAzureRMLogAnalyticsDataExportRule_update (179.22s)
--- PASS: TestAccAzureRMLogAnalyticsStorageInsights_updateStorageAccount (299.46s)
FAIL
FAIL	github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/loganalytics	676.460s
FAIL

tombuildsstuff · 2020-12-09T15:19:07Z

dependent on #9783

tombuildsstuff

hey @favoretti

Thanks for this PR.

Taking a look through this mostly LGTM - if we can fix up the few comments (and the tests pass, once this is rebased on top of #9783) then this should otherwise be good to merge 👍

Thanks!

azurerm/internal/services/loganalytics/log_analytics_linked_storage_account_resource.go

azurerm/internal/services/loganalytics/log_analytics_saved_search_resource.go

azurerm/internal/services/loganalytics/log_analytics_workspace_resource.go

PR #9651 broke `azurerm_security_center_workspace` with passing empty subscriptionId to `parse.LogAnalyticsWorkspaceID.ID()`. This fixes the error.

favoretti · 2020-12-09T16:52:45Z

=== RUN   TestAccAzureRMLogAnalyticsDataExportRule_basic
=== PAUSE TestAccAzureRMLogAnalyticsDataExportRule_basic
=== RUN   TestAccAzureRMLogAnalyticsDataExportRule_requiresImport
=== PAUSE TestAccAzureRMLogAnalyticsDataExportRule_requiresImport
=== RUN   TestAccAzureRMLogAnalyticsDataExportRule_update
=== PAUSE TestAccAzureRMLogAnalyticsDataExportRule_update
=== RUN   TestAccAzureRMLogAnalyticsDataExportRule_complete
=== PAUSE TestAccAzureRMLogAnalyticsDataExportRule_complete
=== RUN   TestAccAzureRMLogAnalyticsDataSourceWindowsEvent_basic
=== PAUSE TestAccAzureRMLogAnalyticsDataSourceWindowsEvent_basic
=== RUN   TestAccAzureRMLogAnalyticsDataSourceWindowsEvent_complete
=== PAUSE TestAccAzureRMLogAnalyticsDataSourceWindowsEvent_complete
=== RUN   TestAccAzureRMLogAnalyticsDataSourceWindowsEvent_update
=== PAUSE TestAccAzureRMLogAnalyticsDataSourceWindowsEvent_update
=== RUN   TestAccAzureRMLogAnalyticsDataSourceWindowsEvent_requiresImport
=== PAUSE TestAccAzureRMLogAnalyticsDataSourceWindowsEvent_requiresImport
=== RUN   TestAccAzureRMLogAnalyticsDataSourceWindowsPerformanceCounter_basic
=== PAUSE TestAccAzureRMLogAnalyticsDataSourceWindowsPerformanceCounter_basic
=== RUN   TestAccAzureRMLogAnalyticsDataSourceWindowsPerformanceCounter_complete
=== PAUSE TestAccAzureRMLogAnalyticsDataSourceWindowsPerformanceCounter_complete
=== RUN   TestAccAzureRMLogAnalyticsDataSourceWindowsPerformanceCounter_update
=== PAUSE TestAccAzureRMLogAnalyticsDataSourceWindowsPerformanceCounter_update
=== RUN   TestAccAzureRMLogAnalyticsDataSourceWindowsPerformanceCounter_requiresImport
=== PAUSE TestAccAzureRMLogAnalyticsDataSourceWindowsPerformanceCounter_requiresImport
=== RUN   TestAccAzureRMLogAnalyticsLinkedService_basic
=== PAUSE TestAccAzureRMLogAnalyticsLinkedService_basic
=== RUN   TestAccAzureRMLogAnalyticsLinkedService_requiresImport
=== PAUSE TestAccAzureRMLogAnalyticsLinkedService_requiresImport
=== RUN   TestAccAzureRMLogAnalyticsLinkedService_complete
=== PAUSE TestAccAzureRMLogAnalyticsLinkedService_complete
=== RUN   TestAccAzureRMlogAnalyticsLinkedStorageAccount_basic
=== PAUSE TestAccAzureRMlogAnalyticsLinkedStorageAccount_basic
=== RUN   TestAccAzureRMlogAnalyticsLinkedStorageAccount_requiresImport
=== PAUSE TestAccAzureRMlogAnalyticsLinkedStorageAccount_requiresImport
=== RUN   TestAccAzureRMlogAnalyticsLinkedStorageAccount_complete
=== PAUSE TestAccAzureRMlogAnalyticsLinkedStorageAccount_complete
=== RUN   TestAccAzureRMlogAnalyticsLinkedStorageAccount_update
=== PAUSE TestAccAzureRMlogAnalyticsLinkedStorageAccount_update
=== RUN   TestAccAzureRMLogAnalyticsSavedSearch_basic
=== PAUSE TestAccAzureRMLogAnalyticsSavedSearch_basic
=== RUN   TestAccAzureRMLogAnalyticsSavedSearch_complete
=== PAUSE TestAccAzureRMLogAnalyticsSavedSearch_complete
=== RUN   TestAccAzureRMLogAnalyticsSavedSearch_withTag
=== PAUSE TestAccAzureRMLogAnalyticsSavedSearch_withTag
=== RUN   TestAccAzureRMLogAnalyticsSavedSearch_requiresImport
=== PAUSE TestAccAzureRMLogAnalyticsSavedSearch_requiresImport
=== RUN   TestAccAzureRMLogAnalyticsSolution_basicContainerMonitoring
=== PAUSE TestAccAzureRMLogAnalyticsSolution_basicContainerMonitoring
=== RUN   TestAccAzureRMLogAnalyticsSolution_requiresImport
=== PAUSE TestAccAzureRMLogAnalyticsSolution_requiresImport
=== RUN   TestAccAzureRMLogAnalyticsSolution_basicSecurity
=== PAUSE TestAccAzureRMLogAnalyticsSolution_basicSecurity
=== RUN   TestAccAzureRMLogAnalyticsStorageInsights_basic
=== PAUSE TestAccAzureRMLogAnalyticsStorageInsights_basic
=== RUN   TestAccAzureRMLogAnalyticsStorageInsights_requiresImport
=== PAUSE TestAccAzureRMLogAnalyticsStorageInsights_requiresImport
=== RUN   TestAccAzureRMLogAnalyticsStorageInsights_complete
=== PAUSE TestAccAzureRMLogAnalyticsStorageInsights_complete
=== RUN   TestAccAzureRMLogAnalyticsStorageInsights_update
=== PAUSE TestAccAzureRMLogAnalyticsStorageInsights_update
=== RUN   TestAccAzureRMLogAnalyticsStorageInsights_updateStorageAccount
=== PAUSE TestAccAzureRMLogAnalyticsStorageInsights_updateStorageAccount
=== RUN   TestAccDataSourceAzureRMLogAnalyticsWorkspace_basic
=== PAUSE TestAccDataSourceAzureRMLogAnalyticsWorkspace_basic
=== RUN   TestAccDataSourceAzureRMLogAnalyticsWorkspace_volumeCapWithDataSource
=== PAUSE TestAccDataSourceAzureRMLogAnalyticsWorkspace_volumeCapWithDataSource
=== RUN   TestAccAzureRMLogAnalyticsWorkspace_basic
=== PAUSE TestAccAzureRMLogAnalyticsWorkspace_basic
=== RUN   TestAccAzureRMLogAnalyticsWorkspace_requiresImport
=== PAUSE TestAccAzureRMLogAnalyticsWorkspace_requiresImport
=== RUN   TestAccAzureRMLogAnalyticsWorkspace_complete
=== PAUSE TestAccAzureRMLogAnalyticsWorkspace_complete
=== RUN   TestAccAzureRMLogAnalyticsWorkspace_freeTier
=== PAUSE TestAccAzureRMLogAnalyticsWorkspace_freeTier
=== RUN   TestAccAzureRMLogAnalyticsWorkspace_withDefaultSku
=== PAUSE TestAccAzureRMLogAnalyticsWorkspace_withDefaultSku
=== RUN   TestAccAzureRMLogAnalyticsWorkspace_withVolumeCap
=== PAUSE TestAccAzureRMLogAnalyticsWorkspace_withVolumeCap
=== RUN   TestAccAzureRMLogAnalyticsWorkspace_removeVolumeCap
=== PAUSE TestAccAzureRMLogAnalyticsWorkspace_removeVolumeCap
=== RUN   TestAccAzureRMLogAnalyticsWorkspace_withInternetIngestionEnabled
=== PAUSE TestAccAzureRMLogAnalyticsWorkspace_withInternetIngestionEnabled
=== RUN   TestAccAzureRMLogAnalyticsWorkspace_withInternetQueryEnabled
=== PAUSE TestAccAzureRMLogAnalyticsWorkspace_withInternetQueryEnabled
=== CONT  TestAccAzureRMLogAnalyticsDataExportRule_basic
=== CONT  TestAccAzureRMLogAnalyticsSavedSearch_requiresImport
=== CONT  TestAccAzureRMLogAnalyticsDataSourceWindowsPerformanceCounter_requiresImport
=== CONT  TestAccAzureRMLogAnalyticsDataSourceWindowsEvent_update
=== CONT  TestAccAzureRMLogAnalyticsDataExportRule_complete
=== CONT  TestAccAzureRMLogAnalyticsDataExportRule_update
=== CONT  TestAccAzureRMLogAnalyticsDataExportRule_requiresImport
=== CONT  TestAccAzureRMLogAnalyticsDataSourceWindowsPerformanceCounter_complete
=== CONT  TestAccAzureRMLogAnalyticsDataSourceWindowsEvent_complete
=== CONT  TestAccAzureRMLogAnalyticsDataSourceWindowsPerformanceCounter_basic
=== CONT  TestAccAzureRMLogAnalyticsDataSourceWindowsPerformanceCounter_update
=== CONT  TestAccAzureRMLogAnalyticsSavedSearch_withTag
=== CONT  TestAccAzureRMLogAnalyticsSavedSearch_complete
=== CONT  TestAccAzureRMLogAnalyticsSavedSearch_basic
=== CONT  TestAccAzureRMlogAnalyticsLinkedStorageAccount_update
=== CONT  TestAccAzureRMlogAnalyticsLinkedStorageAccount_complete
--- PASS: TestAccAzureRMLogAnalyticsSavedSearch_basic (166.26s)
=== CONT  TestAccAzureRMLogAnalyticsDataSourceWindowsEvent_basic
--- PASS: TestAccAzureRMLogAnalyticsSavedSearch_complete (166.27s)
=== CONT  TestAccAzureRMLogAnalyticsWorkspace_withInternetQueryEnabled
--- PASS: TestAccAzureRMLogAnalyticsDataSourceWindowsPerformanceCounter_complete (166.32s)
=== CONT  TestAccAzureRMLogAnalyticsWorkspace_removeVolumeCap
--- PASS: TestAccAzureRMLogAnalyticsDataSourceWindowsPerformanceCounter_basic (166.32s)
=== CONT  TestAccAzureRMLogAnalyticsWorkspace_withInternetIngestionEnabled
--- PASS: TestAccAzureRMLogAnalyticsDataSourceWindowsEvent_complete (166.70s)
=== CONT  TestAccAzureRMLogAnalyticsWorkspace_withVolumeCap
--- PASS: TestAccAzureRMLogAnalyticsDataExportRule_complete (173.03s)
=== CONT  TestAccAzureRMLogAnalyticsWorkspace_withDefaultSku
--- PASS: TestAccAzureRMLogAnalyticsDataExportRule_basic (174.33s)
=== CONT  TestAccAzureRMLogAnalyticsWorkspace_complete
--- PASS: TestAccAzureRMLogAnalyticsDataSourceWindowsPerformanceCounter_requiresImport (174.82s)
=== CONT  TestAccAzureRMLogAnalyticsWorkspace_requiresImport
--- PASS: TestAccAzureRMLogAnalyticsSavedSearch_withTag (177.69s)
=== CONT  TestAccAzureRMLogAnalyticsWorkspace_basic
--- PASS: TestAccAzureRMLogAnalyticsSavedSearch_requiresImport (177.99s)
=== CONT  TestAccDataSourceAzureRMLogAnalyticsWorkspace_volumeCapWithDataSource
--- PASS: TestAccAzureRMLogAnalyticsDataSourceWindowsPerformanceCounter_update (207.56s)
=== CONT  TestAccDataSourceAzureRMLogAnalyticsWorkspace_basic
--- PASS: TestAccAzureRMLogAnalyticsDataExportRule_update (223.39s)
=== CONT  TestAccAzureRMLogAnalyticsStorageInsights_updateStorageAccount
--- PASS: TestAccAzureRMlogAnalyticsLinkedStorageAccount_complete (237.16s)
=== CONT  TestAccAzureRMLogAnalyticsWorkspace_freeTier
--- PASS: TestAccAzureRMLogAnalyticsDataExportRule_requiresImport (243.34s)
=== CONT  TestAccAzureRMLogAnalyticsStorageInsights_update
--- PASS: TestAccAzureRMLogAnalyticsDataSourceWindowsEvent_update (261.24s)
=== CONT  TestAccAzureRMLogAnalyticsStorageInsights_complete
--- PASS: TestAccDataSourceAzureRMLogAnalyticsWorkspace_basic (107.56s)
=== CONT  TestAccAzureRMLogAnalyticsStorageInsights_basic
--- PASS: TestAccAzureRMLogAnalyticsWorkspace_withVolumeCap (161.38s)
=== CONT  TestAccAzureRMLogAnalyticsSolution_basicSecurity
--- PASS: TestAccAzureRMLogAnalyticsDataSourceWindowsEvent_basic (166.72s)
=== CONT  TestAccAzureRMLogAnalyticsSolution_requiresImport
--- PASS: TestAccAzureRMLogAnalyticsWorkspace_withDefaultSku (164.13s)
=== CONT  TestAccAzureRMLogAnalyticsSolution_basicContainerMonitoring
--- PASS: TestAccAzureRMLogAnalyticsWorkspace_complete (163.23s)
=== CONT  TestAccAzureRMLogAnalyticsLinkedService_complete
--- PASS: TestAccAzureRMLogAnalyticsWorkspace_basic (162.33s)
=== CONT  TestAccAzureRMlogAnalyticsLinkedStorageAccount_requiresImport
--- PASS: TestAccAzureRMlogAnalyticsLinkedStorageAccount_update (342.80s)
=== CONT  TestAccAzureRMlogAnalyticsLinkedStorageAccount_basic
--- PASS: TestAccAzureRMLogAnalyticsWorkspace_withInternetQueryEnabled (200.27s)
=== CONT  TestAccAzureRMLogAnalyticsDataSourceWindowsEvent_requiresImport
--- PASS: TestAccAzureRMLogAnalyticsWorkspace_removeVolumeCap (201.20s)
=== CONT  TestAccAzureRMLogAnalyticsLinkedService_requiresImport
--- PASS: TestAccDataSourceAzureRMLogAnalyticsWorkspace_volumeCapWithDataSource (200.10s)
=== CONT  TestAccAzureRMLogAnalyticsLinkedService_basic
--- PASS: TestAccAzureRMLogAnalyticsStorageInsights_complete (127.73s)
=== CONT  TestAccAzureRMLogAnalyticsStorageInsights_requiresImport
--- PASS: TestAccAzureRMLogAnalyticsWorkspace_requiresImport (217.99s)
--- PASS: TestAccAzureRMLogAnalyticsWorkspace_withInternetIngestionEnabled (232.07s)
--- PASS: TestAccAzureRMLogAnalyticsWorkspace_freeTier (162.95s)
--- PASS: TestAccAzureRMLogAnalyticsSolution_basicSecurity (108.57s)
--- PASS: TestAccAzureRMLogAnalyticsStorageInsights_updateStorageAccount (215.03s)
--- PASS: TestAccAzureRMLogAnalyticsSolution_basicContainerMonitoring (106.01s)
--- PASS: TestAccAzureRMLogAnalyticsStorageInsights_basic (143.26s)
--- PASS: TestAccAzureRMLogAnalyticsLinkedService_complete (132.30s)
--- PASS: TestAccAzureRMlogAnalyticsLinkedStorageAccount_basic (128.81s)
--- PASS: TestAccAzureRMLogAnalyticsStorageInsights_update (235.93s)
--- PASS: TestAccAzureRMlogAnalyticsLinkedStorageAccount_requiresImport (155.86s)
--- PASS: TestAccAzureRMLogAnalyticsDataSourceWindowsEvent_requiresImport (132.64s)
--- PASS: TestAccAzureRMLogAnalyticsSolution_requiresImport (178.90s)
--- PASS: TestAccAzureRMLogAnalyticsLinkedService_basic (136.24s)
--- PASS: TestAccAzureRMLogAnalyticsLinkedService_requiresImport (147.09s)
--- PASS: TestAccAzureRMLogAnalyticsStorageInsights_requiresImport (140.54s)

Outside of the cluster tests, for which I'm not eligible, and the breaking change above - we are good.

katbyte

Thanks @favoretti - LGTM 👍

ghost · 2020-12-10T20:19:06Z

This has been released in version 2.40.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.40.0"
}
# ... other configuration ...

ghost · 2021-01-09T14:50:49Z

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

ghost added size/XS size/XL and removed size/XS labels Dec 8, 2020

favoretti changed the title ~~Fix azurerm_security_center_workspace~~ Switch loganalytics to generated resourceids Dec 9, 2020

ghost added size/XXL and removed size/XL labels Dec 9, 2020

tombuildsstuff suggested changes Dec 9, 2020

View reviewed changes

tombuildsstuff added bug refactor service/log-analytics waiting-response labels Dec 9, 2020

favoretti added 17 commits December 9, 2020 17:33

Fix azurerm_security_center_workspace

2138d88

PR #9651 broke `azurerm_security_center_workspace` with passing empty subscriptionId to `parse.LogAnalyticsWorkspaceID.ID()`. This fixes the error.

LAW to generated resourceID

4fd6f08

Fixup tests

e0e4f4a

More resourceids

a501bc0

More resourceids

963ebe6

More resourceids

eb576ee

More resourceids

b93005e

More resourceids

08ff235

Fix tests

da483c9

Fix tests

a08d428

Try another way

34d4373

Try another way

f577003

Last changes, only freTier retention test is failing now

5b5f66b

mod tidy

88905d9

mod vendor cleanup

f45ca09

Uncomment cluster resources

4862762

Restore computed for retention_in_days

664b0b9

ghost removed the waiting-response label Dec 9, 2020

Restore ingestion datasourcetype

a1ea176

favoretti requested review from tombuildsstuff and katbyte December 9, 2020 21:14

katbyte approved these changes Dec 9, 2020

View reviewed changes

katbyte merged commit 8459251 into hashicorp:master Dec 9, 2020

katbyte added this to the v2.40.0 milestone Dec 9, 2020

favoretti deleted the favoretti/security_center_workspace_fix branch December 9, 2020 23:05

tombuildsstuff added a commit that referenced this pull request Dec 10, 2020

clarifying the sdk upgrade from #9764

2430fb4

ghost locked as resolved and limited conversation to collaborators Jan 9, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Switch loganalytics to generated resourceids #9764

Switch loganalytics to generated resourceids #9764

favoretti commented Dec 8, 2020 •

edited

Loading

favoretti commented Dec 9, 2020

tombuildsstuff commented Dec 9, 2020

tombuildsstuff left a comment

favoretti commented Dec 9, 2020

katbyte left a comment

ghost commented Dec 10, 2020

ghost commented Jan 9, 2021

Switch loganalytics to generated resourceids #9764

Switch loganalytics to generated resourceids #9764

Conversation

favoretti commented Dec 8, 2020 • edited Loading

favoretti commented Dec 9, 2020

tombuildsstuff commented Dec 9, 2020

tombuildsstuff left a comment

Choose a reason for hiding this comment

favoretti commented Dec 9, 2020

katbyte left a comment

Choose a reason for hiding this comment

ghost commented Dec 10, 2020

ghost commented Jan 9, 2021

favoretti commented Dec 8, 2020 •

edited

Loading