Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Traffic Manager: support for Geographically routed endpoints #986

Merged
merged 3 commits into from
Mar 16, 2018
Merged

Traffic Manager: support for Geographically routed endpoints #986

merged 3 commits into from
Mar 16, 2018

Conversation

tombuildsstuff
Copy link
Contributor

Adds support for geo_mappings to azurerm_traffic_manager_endpoint and the Geographic traffic_routing_method to azurerm_traffic_manager_profile

@tombuildsstuff
Adding support for Geographic Traffic Routing
375af57
@tombuildsstuff
Adding support for geo mappings
de272d7 
```
$ acctests azurerm TestAccAzureRMTrafficManagerEndpoint_withGeoMappings
=== RUN   TestAccAzureRMTrafficManagerEndpoint_withGeoMappings
--- PASS: TestAccAzureRMTrafficManagerEndpoint_withGeoMappings (89.34s)
PASS
ok  	github.com/terraform-providers/terraform-provider-azurerm/azurerm	89.373s
```
@tombuildsstuff tombuildsstuff added this to the 1.3.1 milestone Mar 16, 2018
@tombuildsstuff tombuildsstuff requested a review from a team March 16, 2018 03:12
@tombuildsstuff tombuildsstuff force-pushed the traffic-manager-endpoints branch from 06f5953 to 8f3242f Compare March 16, 2018 13:29
mbfrahry
mbfrahry approved these changes Mar 16, 2018
View reviewed changes
Copy link
Member

@mbfrahry mbfrahry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tombuildsstuff tombuildsstuff merged commit 8549983 into master Mar 16, 2018
@tombuildsstuff tombuildsstuff deleted the traffic-manager-endpoints branch March 16, 2018 14:43
tombuildsstuff added a commit that referenced this pull request Mar 16, 2018
@tombuildsstuff
Updating to include #986
883c261
@tombuildsstuff
Copy link
Contributor Author

forgot to include the screenshot - tests pass:

screen shot 2018-03-16 at 09 51 42

@ghost
Copy link

ghost commented Mar 31, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mbfrahry mbfrahry mbfrahry approved these changes

Assignees
No one assigned
Labels
enhancement service/traffic-manager
Projects
None yet
Milestone
v1.3.1
Development

Successfully merging this pull request may close these issues.
2 participants
@tombuildsstuff @mbfrahry