Added resource for SQL MI "azurerm_sql_managed_instance" #2727

joranm · 2019-01-21T16:55:05Z

New resource provider for SQL Managed Instance
https://docs.microsoft.com/en-us/azure/sql-database/sql-database-managed-instance

Known issues

Destroys fails due to platform lease on Virtual Server Object (12 hours before it is deleted)

Fixes #1747

joranm · 2019-01-22T20:07:55Z

@katbyte , what is the issue with the megalinter? I'm seeing the same issue with PR #2716

katbyte · 2019-01-23T06:14:16Z

@joranm,

gometalinter removed some linters (megacheck and unused) as they were merged into staticcheck and we didn't pin the tooling version. As a result all linting was failing. It has been resolved in #2722 so merge/rebase on master and it should pass 🙂

joranm · 2019-01-23T08:38:36Z

Hi @katbyte, @tombuildsstuff , did a rebase, and tests have passed successfully.
Regarding the known issue. What would be the best approach?

1) Timeout issue on create (6 hours): Is it possible to implement the Timeout on these resources? I didn't found this feature implemented at any other resource.
2) Lock on dependend resources The creation of SQL Managed Instance does also create a Virtual Server Object and a Network Intent Policy, which locks the subnet and routetable. This object is automatically cleaned after 12 hours after the SQL MI instance removal.

katbyte · 2019-02-19T07:51:39Z

@joranm,

wrt 1 - at the moment we don't have timeouts implemented, that is something we plan to implement for v2.0 so until then tested this will be.. difficult. We have a few ideas but none are idea (an ENV for a pre existing subnet where a MI has already been provisioned for example)

archmangler · 2019-03-18T09:13:25Z

There is a suggestion on #1747 that the creation time has been greatly reduced on the AzureRM side. Has anyone tested if this improves the situation sufficiently to make this provider usable?

pkaminski-degree · 2019-03-29T10:24:09Z

Is this feature planned to be merged any time soon?

jacobm3 · 2019-04-30T21:49:28Z

Any idea when this resource will be merged? Would love to see this available. Thanks!

sarayho1 · 2019-05-01T14:36:14Z

Will this resource be merged and released anytime soon? Received a time-out error running the code with ARM JSON.

TraGicCode · 2019-05-08T14:30:36Z

Would be awesome to see more progress on getting this pushed through!

WascawyWabbit · 2019-05-09T13:11:15Z

Any news on when this will be merged?

katbyte · 2019-05-10T23:10:52Z

@joranm,

I went to run these tests today and got the following build error (as we have updated the azure go sdk)

==> Checking that code complies with gofmt requirements...
go install
# github.com/terraform-providers/terraform-provider-azurerm/azurerm
azurerm/resource_arm_sql_managed_instance.go:143:4: cannot use utils.String(licenseType) (type *string) as type "github.com/Azure/azure-sdk-for-go/services/preview/sql/mgmt/2015-05-01-preview/sql".ManagedInstanceLicenseType in field value
make: *** [build] Error 2

Went to merge master and push but it seems I can't? any chance you could update this se we could see if the instance provisions any faster now

kim0 · 2019-06-04T18:06:07Z

I had opened #3593 and #3587 but apparently this is still WIP. If you have any questions, let me know though

katbyte · 2019-06-04T19:53:23Z

hi @kim0, the new PR is #3575 as this one seems to have been abandoned. Currently it is blocked with:

------- Stdout: -------
=== RUN   TestAccAzureRMSqlMiServer_basic
=== PAUSE TestAccAzureRMSqlMiServer_basic
=== CONT  TestAccAzureRMSqlMiServer_basic
--- FAIL: TestAccAzureRMSqlMiServer_basic (741.07s)
    testing.go:568: Step 0 error: errors during apply:
        
        Error: Code="VnetSubnetConflictWithIntendedPolicy" Message="Route Table. (https://go.microsoft.com/fwlink/?linkid=871071)"
        
          on /opt/teamcity-agent/temp/buildTmp/tf-test102924249/main.tf line 40:
          (source code not available)
        
        
FAIL

so any help on how to resolve that would be fantastic as i am working on other things at the moment.

joranm · 2019-06-05T06:56:21Z

@joranm,
I went to run these tests today and got the following build error (as we have updated the azure go sdk)
==> Checking that code complies with gofmt requirements...
go install

github.com/terraform-providers/terraform-provider-azurerm/azurerm

azurerm/resource_arm_sql_managed_instance.go:143:4: cannot use utils.String(licenseType) (type *string) as type "github.com/Azure/azure-sdk-for-go/services/preview/sql/mgmt/2015-05-01-preview/sql".ManagedInstanceLicenseType in field value
make: *** [build] Error 2

Went to merge master and push but it seems I can't? any chance you could update this se we could see if the instance provisions any faster now

Hi @katbyte,
Provisioning of the first SQL MI in a vnet still takes between 6 and 12 hours. A lot of plumbing is done at the Azure side with regard to building a 5 node cluster, sql data gateway, loadbalancers and so on. I don't expect that the provisioning will be faster in the near future. Is it possible to implement the "timeout" property for Azure resources?

katbyte · 2019-06-06T19:21:46Z

@joranm, I believe that is in the works for v2.0 of the provider

katbyte · 2019-06-06T19:24:54Z

If you could pull in the changes from the PR i opened and or grant us push access to this branch we can take it from here

tombuildsstuff · 2019-06-07T04:17:54Z

Provisioning of the first SQL MI in a vnet still takes between 6 and 12 hours.

@joranm

Indeed, it's better than it was (36h) but it still takes a while; chatting with the SQL Team a while back it turns out there's multiple conditions where the Create/Update call could take this long:

when the cluster this is using under the hood within the subnet is initially built (as you're seeing)
when the cluster is scaled up (for every 5 or so instances/databases within the same subnet)
when the cluster is scaled down (for every 5 or so instances/databases within the same subnet)

Is it possible to implement the "timeout" property for Azure resources?

As @katbyte has mentioned this is something we're doing as a part of the 2.0 release - at this point in time we're working on the dependencies to make that possible (we're working on switching out the Azure Storage SDK at the moment) at which point we should be able to enable Timeout support. However since this requires the Timeout support/this is going to ship in the 2.0 timeframe - I'm going to add this to the 2.0 milestone.

sheigel · 2019-08-05T23:22:43Z

azurerm/resource_arm_sql_managed_instance.go

+				Optional: true,
+				Default:  8,
+				ValidateFunc: validate.IntInSlice([]int{
+					8,


A few weeks ago a smaller number of vcores (4) was introduced:
https://docs.microsoft.com/en-us/azure/sql-database/sql-database-managed-instance-resource-limits#instance-level-resource-limits

It seems worthwhile to have this new resource up to date.

katbyte · 2020-01-25T01:37:17Z

Hi @joranm, i'm going to close this as @mbfrahry has started to move this forward in #5399

ghost · 2020-02-24T16:51:17Z

This has been released in version 2.0.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.0.0"
}
# ... other configuration ...

ghost · 2020-02-25T14:51:36Z

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

ghost added size/XL documentation labels Jan 21, 2019

joranm changed the title ~~Added resource for SQL MI instance~~ Added resource for SQL MI "azurerm_sql_managed_instance" Jan 21, 2019

joranm added 3 commits January 23, 2019 08:40

Added resource for SQL MI instance

ef17f57

Replaces tabs with spaces

bd13782

Removed sweep test

675b72a

tombuildsstuff added new-resource service/mssql Microsoft SQL Server labels Mar 15, 2019

katbyte added the waiting-response label May 10, 2019

katbyte force-pushed the master branch from 77d8dd0 to fa53685 Compare May 12, 2019 19:43

tombuildsstuff added this to the v1.29.0 milestone May 22, 2019

tombuildsstuff self-assigned this May 22, 2019

katbyte modified the milestones: v1.29.0, v1.30.0 May 25, 2019

katbyte mentioned this pull request Jun 1, 2019

New Resource: azurerm_sql_managed_instance (local branch for #2727) #3575

Closed

This was referenced Jun 4, 2019

azurerm_sql_managed_instance does not have fully_qualified_domain_name attribute #3593

Closed

azurerm_sql_managed_instance doesn't support import #3587

Closed

ghost removed the waiting-response label Jun 4, 2019

katbyte removed this from the v1.30.0 milestone Jun 6, 2019

tombuildsstuff added this to the v2.0.0 milestone Jun 7, 2019

This comment has been minimized.

Sign in to view

tombuildsstuff removed their assignment Jun 17, 2019

sheigel reviewed Aug 5, 2019

View reviewed changes

tombuildsstuff mentioned this pull request Aug 19, 2019

Managed SQL database instance #1747

Closed

tombuildsstuff mentioned this pull request Oct 4, 2019

Announcement: Upcoming Changes in Version 2.0 of the Azure Provider #2807

Closed

mbfrahry mentioned this pull request Jan 14, 2020

[WIP] New Resource: azurerm_sql_managed_instance #5399

Closed

katbyte closed this Jan 25, 2020

ghost locked and limited conversation to collaborators Feb 25, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added resource for SQL MI "azurerm_sql_managed_instance" #2727

Added resource for SQL MI "azurerm_sql_managed_instance" #2727

joranm commented Jan 21, 2019 •

edited by tombuildsstuff

Loading

joranm commented Jan 22, 2019

katbyte commented Jan 23, 2019 •

edited

Loading

joranm commented Jan 23, 2019

katbyte commented Feb 19, 2019 •

edited

Loading

archmangler commented Mar 18, 2019

pkaminski-degree commented Mar 29, 2019

jacobm3 commented Apr 30, 2019

sarayho1 commented May 1, 2019

TraGicCode commented May 8, 2019

WascawyWabbit commented May 9, 2019

katbyte commented May 10, 2019

kim0 commented Jun 4, 2019

katbyte commented Jun 4, 2019

joranm commented Jun 5, 2019

github.com/terraform-providers/terraform-provider-azurerm/azurerm

katbyte commented Jun 6, 2019

katbyte commented Jun 6, 2019

tombuildsstuff commented Jun 7, 2019 •

edited

Loading

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

sheigel Aug 5, 2019

katbyte commented Jan 25, 2020

ghost commented Feb 24, 2020

ghost commented Feb 25, 2020

Added resource for SQL MI "azurerm_sql_managed_instance" #2727

Added resource for SQL MI "azurerm_sql_managed_instance" #2727

Conversation

joranm commented Jan 21, 2019 • edited by tombuildsstuff Loading

joranm commented Jan 22, 2019

katbyte commented Jan 23, 2019 • edited Loading

joranm commented Jan 23, 2019

katbyte commented Feb 19, 2019 • edited Loading

archmangler commented Mar 18, 2019

pkaminski-degree commented Mar 29, 2019

jacobm3 commented Apr 30, 2019

sarayho1 commented May 1, 2019

TraGicCode commented May 8, 2019

WascawyWabbit commented May 9, 2019

katbyte commented May 10, 2019

kim0 commented Jun 4, 2019

katbyte commented Jun 4, 2019

joranm commented Jun 5, 2019

github.com/terraform-providers/terraform-provider-azurerm/azurerm

katbyte commented Jun 6, 2019

katbyte commented Jun 6, 2019

tombuildsstuff commented Jun 7, 2019 • edited Loading

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

sheigel Aug 5, 2019

Choose a reason for hiding this comment

katbyte commented Jan 25, 2020

ghost commented Feb 24, 2020

ghost commented Feb 25, 2020

joranm commented Jan 21, 2019 •

edited by tombuildsstuff

Loading

katbyte commented Jan 23, 2019 •

edited

Loading

katbyte commented Feb 19, 2019 •

edited

Loading

tombuildsstuff commented Jun 7, 2019 •

edited

Loading