Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_storage_account: set default for min_tls_version #8152

Merged

Conversation

magodo
Copy link
Collaborator

@magodo magodo commented Aug 18, 2020

For those storage account created using old API version (at least
2018-02-01, before provider v1.29.0), the GET call of new API version
will not return the minimumTLSVersion in response body. So those users
will get a diff.

This PR sets the default value for min_tls_version in case it is
missing in response, using the same value as the default value defined
in schema.

At least fixes the issue encountered by this user comment.

For those storage account created using old API version (at least
2018-02-01, before provider v1.29.0), the GET call of new API version
will not return the `minimumTLSVersion` in response body. So those users
will get a diff.

This PR sets the default value for `min_tls_version` in case it is
missing in response, using the same value as the default value defined
in schema.
Copy link
Collaborator

@WodansSon WodansSon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@magodo, good catch! This LGTM! 🚀

@WodansSon
Copy link
Collaborator

Due to the the particular conditions required to reproduce the issue fixed by this PR I am skipping the normally required full test pass of the resource and running only a single test case on the PR to verify the fix does not cause a regression to the resource. I have been assured by the PR author that this has been manually tested and works as expected.

@WodansSon
Copy link
Collaborator

image

@WodansSon WodansSon merged commit 91a687d into hashicorp:master Aug 18, 2020
WodansSon added a commit that referenced this pull request Aug 18, 2020
@ghost
Copy link

ghost commented Aug 20, 2020

This has been released in version 2.24.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 2.24.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Sep 17, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Sep 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants