Fix cloud storage bucket website params #925
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
Hi, Is there any reason @chrisst - please can this be merged? I'd love to get this fix in for the next release! <3 P. |
|
@stack72 I haven't been able to get domain permissions right on our integration test suite so this isn't well tested yet. I'll take another stab today but if you wanted to build locally and verify the fix it would help! |
modular-magician
force-pushed
the
codegen-pr-2016
branch
from
a911264 to
8706c16
Compare
Signed-off-by: Modular Magician <magic-modules@google.com>
modular-magician
force-pushed
the
codegen-pr-2016
branch
from
8706c16 to
f04c7e5
Compare
|
I got access to our test domain credentials and was able to add tests. |
|
Thanks @chrisst |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original Author: @chrisst