Megan bucket access control #1177
Conversation
ghost
added
modular-magician
force-pushed
the
codegen-pr-2364
branch
from
b9ac980 to
7897e57
Compare
| Type: schema.TypeString, | ||
| Optional: true, | ||
| }, | ||
| "project_team": { |
There was a problem hiding this comment.
It's my understanding that this field is read-only. Did you find that wasn't the case?
| Type: schema.TypeString, | ||
| Required: true, | ||
| }, | ||
| "entity_id": { |
There was a problem hiding this comment.
It's my understanding that this field is read-only. Did you find that wasn't the case?
There was a problem hiding this comment.
This is primarily based on https://cloud.google.com/storage/docs/json_api/v1/bucketAccessControls/insert, which says that only entity and role are configurable.
| }, | ||
|
|
||
| Schema: map[string]*schema.Schema{ | ||
| "bucket": { |
There was a problem hiding this comment.
I suspect this needs to be marked input: true?
| Required: true, | ||
| DiffSuppressFunc: compareSelfLinkOrResourceName, | ||
| }, | ||
| "entity": { |
There was a problem hiding this comment.
I think this should be input: true as well since Read calls out to {{bucket}}/acl/{{entity}}
| @@ -0,0 +1,88 @@ | |||
| // ---------------------------------------------------------------------------- | |||
There was a problem hiding this comment.
Do you mind adding a handwritten test as well, testing update?
modular-magician
force-pushed
the
codegen-pr-2364
branch
from
7897e57 to
c8ab1e2
Compare
Signed-off-by: Modular Magician <magic-modules@google.com>
modular-magician
force-pushed
the
codegen-pr-2364
branch
from
c8ab1e2 to
8da8add
Compare
Original Author: @megan07