Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change CR Domain Mapping route name to string #1563

Merged
merged 1 commit into from
Dec 27, 2019
Merged

Change CR Domain Mapping route name to string #1563

merged 1 commit into from
Dec 27, 2019

Conversation

modular-magician
Copy link
Collaborator

@modular-magician modular-magician commented Dec 27, 2019 •
edited
Loading

Original Author: @emilymye

cloudrun:  Changed `google_cloud_run_domain_mapping` to correctly match Cloud Run API expected format for `spec.route_name`, {serviceName}, instead of invalid projects/{project}/global/services/{serviceName}

cloudrun: Changed `google_cloud_run_domain_mapping` to correctly match Cloud Run API expected format for `spec.route_name`, {serviceName}, instead of invalid projects/{project}/global/services/{serviceName}

@emilymye @modular-magician
Change CR Domain Mapping route name to string
28a9488 
Signed-off-by: Modular Magician <magic-modules@google.com>
@ghost ghost added the size/xs label Dec 27, 2019
@modular-magician modular-magician mentioned this pull request Dec 27, 2019
Merged
@emilymye emilymye merged commit 2fda896 into hashicorp:master Dec 27, 2019
@modular-magician modular-magician deleted the codegen-pr-2889 branch November 15, 2024 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
size/xs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@modular-magician @emilymye