Add docs for the id field #1697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add docs for the id field * fix typo * fix spacing Signed-off-by: Modular Magician <magic-modules@google.com>
ghost
added
modular-magician
deleted the
downstream-pr-db1b8216daee88ea03566763a878e8fba0f75457
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of hashicorp/terraform-provider-google#5542
We never actually documented the
idfield during3.0.0, and according to https://github.com/terraform-providers/terraform-provider-google/wiki/Developer-Best-Practices#self-links-names-and-ids we expect users to use it. Add it to generated resources. Also filed the issue above for handwritten ones too since they're not like a 3 line change.Release Note Template for Downstream PRs (will be copied)
Derived from GoogleCloudPlatform/magic-modules#3040