added boot_disk_kms_key to node_config #1736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Modular Magician <magic-modules@google.com>
ghost
added
modular-magician
deleted the
downstream-pr-7bca75374b244c6bbef92ba080a1dce73f395958
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes hashicorp/terraform-provider-google#5478
Added
boot_disk_kms_keytonode_configblock.This will require us to update the vendor package
google.golang.org/api/container/v1beta1, but the attribute we need hasn't been released yet, and the hash I updated it to for testing, broke another resource. Do I wait for it to be released? Or manually revert the broken package? Or try to find a different hash to update to?Release Note Template for Downstream PRs (will be copied)
Derived from GoogleCloudPlatform/magic-modules#3044