Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check for google_compute_router bgp.advertise_mode. #1776

Conversation

modular-magician
Copy link
Collaborator

Fixes hashicorp/terraform-provider-google#5382

Release Note Template for Downstream PRs (will be copied)

compute: added check on `google_compute_router` for non-empty advertised_groups or advertised_ip_ranges values when advertise_mode is DEFAULT in the bgp block.

Derived from GoogleCloudPlatform/magic-modules#3144

* Add check for google_compute_router bgp.advertise_mode.

* Update templates/terraform/constants/router.go.erb

Co-Authored-By: Dana Hoffman <danahoffman@google.com>

Co-authored-by: Dana Hoffman <danahoffman@google.com>
Signed-off-by: Modular Magician <magic-modules@google.com>
@ghost ghost added the size/xs label Feb 19, 2020
@modular-magician modular-magician merged commit f87d103 into hashicorp:master Feb 19, 2020
@modular-magician modular-magician deleted the downstream-pr-7e246d97fb9724a9374632e50d74abf3c6cfd21c branch November 16, 2024 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add checks for valid google_compute_router.bgp.advertise_mode
1 participant