Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google project precheck #1777

Conversation

modular-magician
Copy link
Collaborator

closes hashicorp/terraform-provider-google#5671 as it's the upstream pr.
fixes hashicorp/terraform-provider-google#5222
references terraform-google-modules/terraform-google-project-factory#373

Release Note Template for Downstream PRs (will be copied)

compute: Updated `google_project` to check for valid permissions on the parent billing account before creating and tainting the resource.

Derived from GoogleCloudPlatform/magic-modules#3145

* project: check for billing account perms as pre-requisite

* outdent

* typo

* rm type from error message

* simplify perms check

* simplify bool check

* simplify bool check

Co-authored-by: Umair Idris <umairidris93@gmail.com>
Signed-off-by: Modular Magician <magic-modules@google.com>
@ghost ghost added the size/xs label Feb 19, 2020
@modular-magician modular-magician merged commit 36d0923 into hashicorp:master Feb 19, 2020
@modular-magician modular-magician deleted the downstream-pr-383425381622e0fff080fd5b8bca7a4c14b084e1 branch November 16, 2024 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Project is getting tainted in TF state file, even though it got created; when billing id is incorrect
1 participant