Add resource for enabling firebase #1885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add resource for enabling firebase * removing whitespace for GA terraform * Change skip_delete to resource level property Signed-off-by: Modular Magician <magic-modules@google.com>
ghost
added
|
@modular-magician Last time I checked Firestore still had to be provisioned manually, do you know if this is still the case? |
|
@chrisst's comment on hashicorp/terraform-provider-google#2973 (comment) suggests otherwise, I'd suggest following up there if you find it still doesn't work. (I only happened to notice this comment by accident, |
modular-magician
deleted the
downstream-pr-36062b0887e96048581857f79b709e68bdb5d8ca
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also adding a new feature to generated tests to not attempt to validate resources with CheckDestroy if they aren't deletable.
My testing so far as been with service accounts and, unless my environment is leaking personal credentials, the API is tolerating it just fine. Even though the official Firebase documentation contradicts this.
Release Note Template for Downstream PRs (will be copied)
PR for hashicorp/terraform-provider-google#2973
Derived from GoogleCloudPlatform/magic-modules#3281