Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not retry requests without GetBody #1894

Conversation

modular-magician
Copy link
Collaborator

Now, if a request doesn't have GetBody (to copy the request), the request is treated as nonretryable and just sent once as is.

Fixes hashicorp/terraform-provider-google#5970

Release Note Template for Downstream PRs (will be copied)

provider: Fixed an error with resources failing to upload large files (e.g. with `google_storage_bucket_object`) during retried requests

Derived from GoogleCloudPlatform/magic-modules#3299

Signed-off-by: Modular Magician <magic-modules@google.com>
@ghost ghost added the size/m label Mar 25, 2020
@modular-magician modular-magician merged commit 28acb9a into hashicorp:master Mar 25, 2020
danawillow pushed a commit that referenced this pull request Mar 25, 2020
Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician deleted the downstream-pr-a3d72e39766f490f5b614e7c251e55be435932e1 branch November 16, 2024 03:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

unable to upload google_storage_bucket_objects larger than ~16MiB (16777215 bytes)
1 participant