Storage bucket: Surface non-retryable object delete error #1929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…3336) * Storage bucket: Surface non-retryable object delete error * storage: test deleting bucket with non-deletable objects error Signed-off-by: Modular Magician <magic-modules@google.com>
ghost
added
the
modular-magician
deleted the
downstream-pr-5e208eaecc69409400f848df6c131b8023728992
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release Note Template for Downstream PRs (will be copied)
This PR fixes a bug when Storage Bucket delete operation is stuck in a never-ending loop when it can't delete objects - fixes hashicorp/terraform-provider-google#6034.
Please see the above-mentioned ticket on how to reproduce the issue.
With this PR in place, the terraform will give up when hitting a non-retryable error during objects delete (we will still try to delete the bucket in case we can):
I tried to add a test to cover this issue, but didn't find a way how to test Error on destroy with current
Test()plumbing. If this is desirable I would appreciate help on how to best implement the test.Derived from GoogleCloudPlatform/magic-modules#3336