Add support for multiple formats for pubsub refs in source repo #1938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…icorp#3339) * Add support for multiple formats for pubsub refs in source repo (a TypeMap's key_value). * Add docs * Return string * Handle err, assert type * Assert more types * Use empty strings, not nils * Update overrides/terraform/property_override.rb * Pull utils function to source_repo_utils, make regex constant * fmt Signed-off-by: Modular Magician <magic-modules@google.com>
ghost
added
the
modular-magician
deleted the
downstream-pr-fd7b937b7caf295be1ecc70665e27615a398e95f
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes hashicorp/terraform-provider-google#6036
Release Note Template for Downstream PRs (will be copied)
Derived from GoogleCloudPlatform/magic-modules#3339