Add Firebase WebApp resource #1950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add Firebase WebApp resource Signed-off-by: Matt Morrissette <yinzara@gmail.com> * Add "config" to Firebase WebApp * Add "google_firebase_web_app" data source * Exclude update from async op * Add datasource and an update test. Add the google_firebase_web_app_config data source Test for updating google_firebase_web_app resource * Get import working and fix build * Adding documentation Docs for both web app datasources Adding resources to the website side bar * exclude beta data source * removing comments Co-authored-by: Chris Stephens <chrisst@google.com> Signed-off-by: Modular Magician <magic-modules@google.com>
ghost
added
modular-magician
deleted the
downstream-pr-d0fad39b48aab4d7ed5cbe58e93cf55b23e50ef8
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a custom "decoder" to support the "config" subelement. I originally considered a fine grained resource but since it cannot be modified, I opted for a nested element. I also added the associated data source.
Derived from GoogleCloudPlatform/magic-modules#3340