Per instance config delete underlying instance #2187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Adding virtual field to control deletion of state after config is deleted * Add support for deleting underlying instances for stateful MIG via virtual field. Poll for delete * Update comment in test * Remove token param if no token defined * Add update tests Signed-off-by: Modular Magician <magic-modules@google.com>
ghost
added
emilymye
pushed a commit
that referenced
this pull request
Jun 17, 2020
* Adding virtual field to control deletion of state after config is deleted * Add support for deleting underlying instances for stateful MIG via virtual field. Poll for delete * Update comment in test * Remove token param if no token defined * Add update tests Signed-off-by: Modular Magician <magic-modules@google.com>
emilymye
pushed a commit
that referenced
this pull request
Jun 17, 2020
* Adding virtual field to control deletion of state after config is deleted * Add support for deleting underlying instances for stateful MIG via virtual field. Poll for delete * Update comment in test * Remove token param if no token defined * Add update tests Signed-off-by: Modular Magician <magic-modules@google.com>
modular-magician
deleted the
downstream-pr-cfea6e402fa82d6e8605767299c0e84a0fe3bc2d
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: hashicorp/terraform-provider-google#6548
Release Note Template for Downstream PRs (will be copied)
Derived from GoogleCloudPlatform/magic-modules#3635