Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

several fixes for notebook instance #2288

Conversation

modular-magician
Copy link
Collaborator

Fixes hashicorp/terraform-provider-google#6798. Tests are also more comprehensive now.

Release Note Template for Downstream PRs (will be copied)

notebook: fixed bug where updating certain fields would result in a no-op update call instead of a create/destroy. Now, the only field that is updatable in place is `labels`
notebook: fixed bug where many fields were being written as empty to state, causing a diff on the next plan
notebook: fixed bug where setting `network` or `subnet` to a full URL would succeed, but cause a diff on the next plan

Derived from GoogleCloudPlatform/magic-modules#3761

Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician merged commit 7b66b35 into hashicorp:master Jul 21, 2020
@modular-magician modular-magician deleted the downstream-pr-3e9e628bc12e7ec03344ef2a7380635d5d3cfb2d branch November 16, 2024 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant