Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

more notebook instance fixes #2332

Conversation

modular-magician
Copy link
Collaborator

This was probably an API-side change that we're reacting to, since the initial test failures don't line up with any obvious changes on our side.

Fixes hashicorp/terraform-provider-google#6915
Fixes hashicorp/terraform-provider-google#6798

Release Note Template for Downstream PRs (will be copied)

notebook: fixed bug where not setting `data_disk_type` or `disk_encryption` would cause a diff on the next plan

Derived from GoogleCloudPlatform/magic-modules#3815

Signed-off-by: Modular Magician <magic-modules@google.com>
@ghost ghost added the size/xs label Aug 4, 2020
@modular-magician modular-magician merged commit f5c1e01 into hashicorp:master Aug 4, 2020
@modular-magician modular-magician deleted the downstream-pr-6646766738b0c476f89ba6add1c8ea32dfa61f06 branch November 16, 2024 03:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
1 participant