Make path_rule Optional in google_url_map's path_matcher block. #118
Conversation
|
|
||
| func testAccComputeUrlMap_noPathRules(bsName, hcName, umName string) string { | ||
| return fmt.Sprintf(` | ||
| resource "google_compute_backend_service" "foobar" { |
There was a problem hiding this comment.
Can you update the indentation and line up the spacing in these resources?
i.e. for this one:
resource "google_compute_backend_service" "foobar" {
name = "urlmap-test-%s"
health_checks = ["${google_compute_http_health_check.zero.self_link}"]
}
|
|
||
| * `name` - (Required) The name of the `path_matcher` resource. Used by the | ||
| `host_rule` block above. | ||
| * `default_service` - (Required) The URL or [valid partial url](https://cloud.google.com/compute/docs/reference/latest/urlMaps#pathMatcher.defaultService) |
There was a problem hiding this comment.
If a valid partial url is set, will it return that same partial url on read? my gut says no, in which case we should request the full url to avoid perpetual diffs (or needing to set it to computed).
| } | ||
|
|
||
| resource "google_compute_url_map" "foobar" { | ||
| name = "urlmap-test-%s" | ||
| default_service = "${google_compute_backend_service.foobar.self_link}" | ||
| name = "urlmap-test-%s" |
There was a problem hiding this comment.
Looks like a few of these have spaces instead of tabs, which is messing up the indentation in github
| } | ||
|
|
||
| resource "google_compute_url_map" "foobar" { | ||
| name = "urlmap-test-%s" | ||
| default_service = "${google_compute_backend_service.foobar.self_link}" | ||
| name = "urlmap-test-%s" |
| } | ||
|
|
||
| resource "google_compute_url_map" "foobar" { | ||
| name = "urlmap-test-%s" | ||
| default_service = "${google_compute_backend_service.foobar.self_link}" | ||
| name = "urlmap-test-%s" |
| } | ||
|
|
||
| resource "google_compute_url_map" "foobar" { | ||
| name = "urlmap-test-%s" | ||
| default_service = "${google_compute_backend_service.foobar.self_link}" | ||
| name = "urlmap-test-%s" |
| } | ||
|
|
||
| resource "google_compute_url_map" "foobar" { | ||
| name = "urlmap-test-%s" |
|
@danawillow: Done for all. The test configurations were indented with spaces, so I updated them to tabs like most of our other configurations. |
|
LGTM, merge at will |
…icorp#118) * Made path_rule optional for path_matcher in google_compute_url_map. * Updated google_compute_url_map docs. * Updated test configuration formatting.
…icorp#118) * Made path_rule optional for path_matcher in google_compute_url_map. * Updated google_compute_url_map docs. * Updated test configuration formatting.
…icorp#118) * Made path_rule optional for path_matcher in google_compute_url_map. * Updated google_compute_url_map docs. * Updated test configuration formatting.
Magic Modules changes.
Magic Modules changes.
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
ghost
locked and limited conversation to collaborators
Make path_rule Optional in google_url_map's path_matcher block.
Fixes #113
@danawillow