Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gke node taints #1264

Merged
merged 1 commit into from
Mar 27, 2018
Merged

Add gke node taints #1264

merged 1 commit into from
Mar 27, 2018

Conversation

danawillow
Copy link
Contributor

Fixes #680

@emilymye
Copy link
Contributor

emilymye commented Mar 27, 2018

LGTM

$ make testacc TEST=./google TESTARGS="-run='TestAccContainerCluster_withNodeConfigTaints'"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./google -v -run='TestAccContainerCluster_withNodeConfigTaints' -timeout 120m
=== RUN   TestAccContainerCluster_withNodeConfigTaints
=== PAUSE TestAccContainerCluster_withNodeConfigTaints
=== CONT  TestAccContainerCluster_withNodeConfigTaints
--- PASS: TestAccContainerCluster_withNodeConfigTaints (214.99s)
PASS
ok  	github.com/terraform-providers/terraform-provider-google/google	215.175s

$ $ make testacc TEST=./google TESTARGS="-run='TestAccContainerNodePool_withNodeConfigTaints'"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./google -v -run='TestAccContainerNodePool_withNodeConfigTaints' -timeout 120m
=== RUN   TestAccContainerNodePool_withNodeConfigTaints
=== PAUSE TestAccContainerNodePool_withNodeConfigTaints
=== CONT  TestAccContainerNodePool_withNodeConfigTaints
^[^[--- PASS: TestAccContainerNodePool_withNodeConfigTaints (416.72s)
PASS
ok  	github.com/terraform-providers/terraform-provider-google/google	416.895s

@emilymye emilymye merged commit e53b24b into hashicorp:master Mar 27, 2018
@AndreaGiardini
Copy link

Do we need to docs for this feature? I can't find it in the official documentation https://www.terraform.io/docs/providers/google/r/container_node_pool.html

@danawillow
Copy link
Contributor Author

It's at https://www.terraform.io/docs/providers/google/r/container_cluster.html#taint, since it's part of the node_config, which is common between the cluster and the node pool.

@danawillow danawillow deleted the is-680 branch May 9, 2018 18:03
@ghost
Copy link

ghost commented Nov 18, 2018

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants