Add issue_client_certificate to cluster

[emilymye]

Fixes #1378.

• Also changed test name so go test filter doesn't conflict with MasterAuthorization...Tests

make testacc TEST=./google TESTARGS='--run="TestAccContainerCluster_withMasterAuthConfig"'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./google -v --run="TestAccContainerCluster_withMasterAuthConfig" -timeout 120m
=== RUN TestAccContainerCluster_withMasterAuthConfig
=== PAUSE TestAccContainerCluster_withMasterAuthConfig
=== RUN TestAccContainerCluster_withMasterAuthConfig_NoCert
=== PAUSE TestAccContainerCluster_withMasterAuthConfig_NoCert
=== CONT TestAccContainerCluster_withMasterAuthConfig
=== CONT TestAccContainerCluster_withMasterAuthConfig_NoCert
--- PASS: TestAccContainerCluster_withMasterAuthConfig_NoCert (394.82s)
--- PASS: TestAccContainerCluster_withMasterAuthConfig (396.11s)
PASS
ok github.com/terraform-providers/terraform-provider-google/google 396.281s

TF_ACC=1 go test ./google -v --run="TestAccContainerClusterDatasource_basic" -timeout 120m
=== RUN TestAccContainerClusterDatasource_basic
=== PAUSE TestAccContainerClusterDatasource_basic
=== CONT TestAccContainerClusterDatasource_basic
--- PASS: TestAccContainerClusterDatasource_basic (311.69s)
PASS
ok github.com/terraform-providers/terraform-provider-google/google 311.870s

[rosbo]

If you set issue_client_certificate to true in a else statement to this if, I think it would simplify masterAuthClientCertCfgSuppress since it will only need to handle one case:
[{ "issue_client_certificate": true}] --> []

[emilymye]

I wanted to do it like that first :/ The problem with that approach is that we don't actually have access to the old data (i.e. issue_client_certificate=true) in the diff suppress function, and because the new value is nil, it doesn't attempt to do the diff of issue_client_certificate.

[rosbo]

I see 👍

[ellipticasec]

Thanks @emilymye you rock !

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!