Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/compute_instance_template: Make disk.device_name computed #566

Merged
merged 1 commit into from
Oct 10, 2017

Conversation

radeksimko
Copy link
Member

This is to address a breaking API change which occurred between yesterday and today. Last night's tests passed, but are now failing.

Test results (after patch)

=== RUN   TestAccComputeInstanceTemplate_importBasic
--- PASS: TestAccComputeInstanceTemplate_importBasic (26.45s)
=== RUN   TestAccComputeInstanceTemplate_importIp
--- PASS: TestAccComputeInstanceTemplate_importIp (47.83s)
=== RUN   TestAccComputeInstanceTemplate_importDisks
--- PASS: TestAccComputeInstanceTemplate_importDisks (27.77s)
=== RUN   TestAccComputeInstanceTemplate_importSubnetAuto
--- PASS: TestAccComputeInstanceTemplate_importSubnetAuto (107.90s)
=== RUN   TestAccComputeInstanceTemplate_importSubnetCustom
--- PASS: TestAccComputeInstanceTemplate_importSubnetCustom (90.38s)
=== RUN   TestAccComputeInstanceTemplate_basic
--- PASS: TestAccComputeInstanceTemplate_basic (24.88s)
=== RUN   TestAccComputeInstanceTemplate_preemptible
--- PASS: TestAccComputeInstanceTemplate_preemptible (25.28s)
=== RUN   TestAccComputeInstanceTemplate_IP
--- PASS: TestAccComputeInstanceTemplate_IP (50.13s)
=== RUN   TestAccComputeInstanceTemplate_networkIP
--- PASS: TestAccComputeInstanceTemplate_networkIP (24.77s)
=== RUN   TestAccComputeInstanceTemplate_disks
--- PASS: TestAccComputeInstanceTemplate_disks (25.09s)
=== RUN   TestAccComputeInstanceTemplate_subnet_auto
--- PASS: TestAccComputeInstanceTemplate_subnet_auto (107.73s)
=== RUN   TestAccComputeInstanceTemplate_subnet_custom
--- PASS: TestAccComputeInstanceTemplate_subnet_custom (89.12s)

@radeksimko radeksimko merged commit 31dc9d3 into master Oct 10, 2017
@radeksimko radeksimko deleted the b-inst-tpl-device-name-computed branch October 10, 2017 19:37
negz pushed a commit to negz/terraform-provider-google that referenced this pull request Oct 17, 2017
…device-name-computed

r/compute_instance_template: Make disk.device_name computed
luis-silva pushed a commit to luis-silva/terraform-provider-google that referenced this pull request May 21, 2019
…ame from fields empty va… (hashicorp#566)

<!-- This change is generated by MagicModules. -->
/cc @nstogner
@ghost
Copy link

ghost commented Mar 30, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants