Make google_project_services resource importable #601
Conversation
| @@ -71,6 +74,7 @@ func resourceGoogleProjectServicesRead(d *schema.ResourceData, meta interface{}) | |||
| return err | |||
| } | |||
|
|
|||
| d.Set("project", d.Id()) | |||
There was a problem hiding this comment.
Should project content be checked before overwriting?
There was a problem hiding this comment.
Eh I don't think it needs to be but may as well throw an error
There was a problem hiding this comment.
Thanks @pdecat! This looks good overall, just one quick piece of feedback.
| }) | ||
| } | ||
|
|
||
| func testAccGoogleProjectServices_import(projectId, orgId, projectName string) string { |
There was a problem hiding this comment.
Since this is so similar to testAccGoogleProjectAssociateServicesBasic from resource_google_project_services_test.go, what if you just called that function instead of having a new one here?
…le_project_services_test.go
There was a problem hiding this comment.
$ make testacc TEST=./google TESTARGS='-run=TestAccGoogleProjectServices -parallel 8' GOOGLE_USE_DEFAULT_CREDENTIALS=true
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./google -v -run=TestAccGoogleProjectServices -parallel 8 -timeout 120m
=== RUN TestAccGoogleProjectServices_importBasic
=== RUN TestAccGoogleProjectServices_basic
=== RUN TestAccGoogleProjectServices_authoritative
=== RUN TestAccGoogleProjectServices_authoritative2
=== RUN TestAccGoogleProjectServices_ignoreUnenablableServices
=== RUN TestAccGoogleProjectServices_manyServices
2017/10/23 13:46:41 [DEBUG]: Converted list of strings to "iam.googleapis.com","cloudresourcemanager.googleapis.com","servicemanagement.googleapis.com"
--- PASS: TestAccGoogleProjectServices_authoritative (82.30s)
--- PASS: TestAccGoogleProjectServices_authoritative2 (86.61s)
--- PASS: TestAccGoogleProjectServices_importBasic (107.42s)
--- PASS: TestAccGoogleProjectServices_basic (118.30s)
--- PASS: TestAccGoogleProjectServices_ignoreUnenablableServices (408.47s)
--- PASS: TestAccGoogleProjectServices_manyServices (1204.45s)
PASS
ok github.com/terraform-providers/terraform-provider-google/google 1204.612s
* Make google_project_services resource importable * Reuse testAccGoogleProjectAssociateServicesBasic() from resource_google_project_services_test.go
<!-- This change is generated by MagicModules. --> Original Author: @chrisst
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
ghost
locked and limited conversation to collaborators
No description provided.