google_dataflow_job - added job_id attribute #5644
Conversation
jeet-parekh
commented
Feb 11, 2020
•
jeet-parekh
commented
ghost
requested a review
from
| @@ -10,7 +10,7 @@ import ( | |||
| "github.com/hashicorp/terraform-plugin-sdk/helper/validation" | |||
|
|
|||
| "github.com/hashicorp/terraform-plugin-sdk/helper/resource" | |||
| "google.golang.org/api/dataflow/v1b3" | |||
| dataflow "google.golang.org/api/dataflow/v1b3" | |||
There was a problem hiding this comment.
dataflow was added automatically by the go tools... confused whether or not this is correct
| "job_id": { | ||
| Type: schema.TypeString, | ||
| Computed: true, | ||
| }, |
There was a problem hiding this comment.
should I add ForceNew: true as well?
There was a problem hiding this comment.
ForceNew is only applicable on input fields. It signifies that the field is not updatable, and if the value changes a new resource needs to be recreated. Because job_id is read only, it is not needed here. Good question!
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
ghost
locked and limited conversation to collaborators
